]> git.lizzy.rs Git - rust.git/commitdiff
tidy: Fix a regression in `#[test]` detection in libcore
authorVadim Petrochenkov <vadim.petrochenkov@gmail.com>
Thu, 25 Jul 2019 22:22:59 +0000 (01:22 +0300)
committerVadim Petrochenkov <vadim.petrochenkov@gmail.com>
Sat, 27 Jul 2019 14:26:55 +0000 (17:26 +0300)
`contents` is the whole file rather than a single line.

src/tools/tidy/src/unit_tests.rs

index 579a20e1142bea7d9d1959516a606ddcd328c54e..6c61144f2793127d9df0e932bfd5131530c9df29 100644 (file)
@@ -13,14 +13,16 @@ pub fn check(path: &Path, bad: &mut bool) {
         &mut |entry, contents| {
             let subpath = entry.path();
             if let Some("rs") = subpath.extension().and_then(|e| e.to_str()) {
-                let contents = contents.trim();
-                if !contents.starts_with("//") && contents.contains("#[test]") {
-                    tidy_error!(
-                        bad,
-                        "`{}` contains `#[test]`; libcore tests must be placed inside \
-                        `src/libcore/tests/`",
-                        subpath.display()
-                    );
+                for line in contents.lines() {
+                    let line = line.trim();
+                    if !line.starts_with("//") && line.contains("#[test]") {
+                        tidy_error!(
+                            bad,
+                            "`{}` contains `#[test]`; libcore tests must be placed inside \
+                            `src/libcore/tests/`",
+                            subpath.display()
+                        );
+                    }
                 }
             }
         },