]> git.lizzy.rs Git - rust.git/commitdiff
Pass `branch.{branch}.remote=origin` to `git submodule update`
authorJoshua Nelson <github@jyn.dev>
Sat, 24 Dec 2022 02:02:34 +0000 (20:02 -0600)
committerJoshua Nelson <github@jyn.dev>
Sat, 24 Dec 2022 02:10:22 +0000 (20:10 -0600)
This works around a bug in git itself; see
https://github.com/rust-lang/rust/issues/101144.

src/bootstrap/lib.rs

index f84fcd21cfcfeacb7be2938ed3e5239377822a48..5cdd841cd6ed0b7d64993f57365a209ca142e8b7 100644 (file)
 use std::io;
 use std::io::ErrorKind;
 use std::path::{Path, PathBuf};
-use std::process::Command;
+use std::process::{Command, Stdio};
 use std::str;
 
 use channel::GitInfo;
@@ -661,12 +661,32 @@ fn dir_is_empty(dir: &Path) -> bool {
 
         // Try passing `--progress` to start, then run git again without if that fails.
         let update = |progress: bool| {
-            let mut git = Command::new("git");
+            // Git is buggy and will try to fetch submodules from the tracking branch for *this* repository,
+            // even though that has no relation to the upstream for the submodule.
+            let current_branch = {
+                let output = self
+                    .config
+                    .git()
+                    .args(["symbolic-ref", "--short", "HEAD"])
+                    .stderr(Stdio::inherit())
+                    .output();
+                let output = t!(output);
+                if output.status.success() {
+                    Some(String::from_utf8(output.stdout).unwrap().trim().to_owned())
+                } else {
+                    None
+                }
+            };
+
+            let mut git = self.config.git();
+            if let Some(branch) = current_branch {
+                git.arg("-c").arg(format!("branch.{branch}.remote=origin"));
+            }
             git.args(&["submodule", "update", "--init", "--recursive", "--depth=1"]);
             if progress {
                 git.arg("--progress");
             }
-            git.arg(relative_path).current_dir(&self.config.src);
+            git.arg(relative_path);
             git
         };
         // NOTE: doesn't use `try_run` because this shouldn't print an error if it fails.