]> git.lizzy.rs Git - rust.git/commitdiff
Take DiagnosticInfo in privacy_error
authorJoshua Nelson <jyn514@gmail.com>
Mon, 5 Apr 2021 09:15:57 +0000 (05:15 -0400)
committerJoshua Nelson <jyn514@gmail.com>
Mon, 5 Apr 2021 18:32:13 +0000 (14:32 -0400)
src/librustdoc/passes/collect_intra_doc_links.rs

index d0ece91f014628c96f95b05465717927ed3070a6..59981a2f85265288d2af9af2ad9d2dc77743e554 100644 (file)
@@ -1192,7 +1192,7 @@ fn resolve_link(
                 if self.cx.tcx.privacy_access_levels(LOCAL_CRATE).is_exported(hir_src)
                     && !self.cx.tcx.privacy_access_levels(LOCAL_CRATE).is_exported(hir_dst)
                 {
-                    privacy_error(self.cx, &item, &path_str, dox, &ori_link);
+                    privacy_error(self.cx, diag_info, &path_str);
                 }
             }
 
@@ -2045,7 +2045,11 @@ fn suggest_disambiguator(
 }
 
 /// Report a link from a public item to a private one.
-fn privacy_error(cx: &DocContext<'_>, item: &Item, path_str: &str, dox: &str, link: &MarkdownLink) {
+fn privacy_error(
+    cx: &DocContext<'_>,
+    DiagnosticInfo { item, ori_link: _, dox, link_range }: DiagnosticInfo<'_>,
+    path_str: &str,
+) {
     let sym;
     let item_name = match item.name {
         Some(name) => {
@@ -2057,7 +2061,7 @@ fn privacy_error(cx: &DocContext<'_>, item: &Item, path_str: &str, dox: &str, li
     let msg =
         format!("public documentation for `{}` links to private item `{}`", item_name, path_str);
 
-    report_diagnostic(cx.tcx, PRIVATE_INTRA_DOC_LINKS, &msg, item, dox, &link.range, |diag, sp| {
+    report_diagnostic(cx.tcx, PRIVATE_INTRA_DOC_LINKS, &msg, item, dox, &link_range, |diag, sp| {
         if let Some(sp) = sp {
             diag.span_label(sp, "this item is private");
         }