/// # Panics
///
/// When calling `sum` and a primitive integer type is being returned, this
- /// method will panic if the computation overflows.
+ /// method will panic if the computation overflows and debug assertions are
+ /// enabled.
///
/// # Examples
///
/// # Panics
///
/// When calling `product` and a primitive integer type is being returned,
- /// this method will panic if the computation overflows.
+ /// method will panic if the computation overflows and debug assertions are
+ /// enabled.
///
/// # Examples
///
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.
+use ops::{Mul, Add};
/// Conversion from an `Iterator`.
///
fn product<I: Iterator<Item=A>>(iter: I) -> Self;
}
+// NB: explicitly use Add and Mul here to inherit overflow checks
macro_rules! integer_sum_product {
($($a:ident)*) => ($(
#[stable(feature = "iter_arith_traits", since = "1.12.0")]
impl Sum for $a {
+ #[rustc_inherit_overflow_checks]
fn sum<I: Iterator<Item=$a>>(iter: I) -> $a {
- iter.fold(0, |a, b| {
- a.checked_add(b).expect("overflow in sum")
- })
+ iter.fold(0, Add::add)
}
}
#[stable(feature = "iter_arith_traits", since = "1.12.0")]
impl Product for $a {
fn product<I: Iterator<Item=$a>>(iter: I) -> $a {
- iter.fold(1, |a, b| {
- a.checked_mul(b).expect("overflow in product")
- })
+ iter.fold(1, Mul::mul)
}
}
#[stable(feature = "iter_arith_traits", since = "1.12.0")]
impl<'a> Sum<&'a $a> for $a {
fn sum<I: Iterator<Item=&'a $a>>(iter: I) -> $a {
- iter.fold(0, |a, b| {
- a.checked_add(*b).expect("overflow in sum")
- })
+ iter.cloned().fold(0, Add::add)
}
}
#[stable(feature = "iter_arith_traits", since = "1.12.0")]
impl<'a> Product<&'a $a> for $a {
fn product<I: Iterator<Item=&'a $a>>(iter: I) -> $a {
- iter.fold(1, |a, b| {
- a.checked_mul(*b).expect("overflow in product")
- })
+ iter.cloned().fold(1, Mul::mul)
}
}
)*)
--- /dev/null
+// Copyright 2016 The Rust Project Developers. See the COPYRIGHT
+// file at the top-level directory of this distribution and at
+// http://rust-lang.org/COPYRIGHT.
+//
+// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
+// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
+// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
+// option. This file may not be copied, modified, or distributed
+// except according to those terms.
+
+// compile-flags: -C debug_assertions=yes
+
+use std::panic;
+
+fn main() {
+ let r = panic::catch_unwind(|| {
+ [1, i32::max_value()].iter().sum::<i32>();
+ });
+ assert!(r.is_err());
+
+ let r = panic::catch_unwind(|| {
+ [2, i32::max_value()].iter().product::<i32>();
+ });
+ assert!(r.is_err());
+
+ let r = panic::catch_unwind(|| {
+ [1, i32::max_value()].iter().cloned().sum::<i32>();
+ });
+ assert!(r.is_err());
+
+ let r = panic::catch_unwind(|| {
+ [2, i32::max_value()].iter().cloned().product::<i32>();
+ });
+ assert!(r.is_err());
+}
--- /dev/null
+// Copyright 2016 The Rust Project Developers. See the COPYRIGHT
+// file at the top-level directory of this distribution and at
+// http://rust-lang.org/COPYRIGHT.
+//
+// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
+// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
+// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
+// option. This file may not be copied, modified, or distributed
+// except according to those terms.
+
+// compile-flags: -C debug_assertions=no
+
+fn main() {
+ assert_eq!([1i32, i32::max_value()].iter().sum::<i32>(),
+ 1i32.wrapping_add(i32::max_value()));
+ assert_eq!([2i32, i32::max_value()].iter().product::<i32>(),
+ 2i32.wrapping_mul(i32::max_value()));
+
+ assert_eq!([1i32, i32::max_value()].iter().cloned().sum::<i32>(),
+ 1i32.wrapping_add(i32::max_value()));
+ assert_eq!([2i32, i32::max_value()].iter().cloned().product::<i32>(),
+ 2i32.wrapping_mul(i32::max_value()));
+}