]> git.lizzy.rs Git - rust.git/commitdiff
Fix ICE on failure to parse token tree
authorJeffrey Seyfried <jeffrey.seyfried@gmail.com>
Wed, 25 May 2016 20:05:47 +0000 (20:05 +0000)
committerJeffrey Seyfried <jeffrey.seyfried@gmail.com>
Thu, 26 May 2016 01:20:55 +0000 (01:20 +0000)
src/libsyntax/parse/parser.rs
src/test/parse-fail/issue-33569.rs [new file with mode: 0644]

index 3a28632f07a7e55ec7953d250dc4c803debd0e62..9f4a773973ec265482f1e0b1b7aafd68dc06f4cb 100644 (file)
@@ -2702,7 +2702,10 @@ fn parse_unquoted(&mut self) -> PResult<'a, TokenTree> {
                     return Ok(TokenTree::Token(sp, SpecialVarNt(SpecialMacroVar::CrateMacroVar)));
                 } else {
                     sp = mk_sp(sp.lo, self.span.hi);
-                    self.parse_ident()?
+                    self.parse_ident().unwrap_or_else(|mut e| {
+                        e.emit();
+                        keywords::Invalid.ident()
+                    })
                 }
             }
             token::SubstNt(name) => {
@@ -2845,7 +2848,7 @@ pub fn parse_token_tree(&mut self) -> PResult<'a, TokenTree> {
                         // and an error emitted then. Thus we don't pop from
                         // self.open_braces here.
                     },
-                    _ => unreachable!(),
+                    _ => {}
                 }
 
                 Ok(TokenTree::Delimited(span, Rc::new(Delimited {
diff --git a/src/test/parse-fail/issue-33569.rs b/src/test/parse-fail/issue-33569.rs
new file mode 100644 (file)
index 0000000..130278d
--- /dev/null
@@ -0,0 +1,18 @@
+// Copyright 2016 The Rust Project Developers. See the COPYRIGHT
+// file at the top-level directory of this distribution and at
+// http://rust-lang.org/COPYRIGHT.
+//
+// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
+// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
+// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
+// option. This file may not be copied, modified, or distributed
+// except according to those terms.
+
+// compile-flags: -Z no-analysis
+
+macro_rules! foo {
+    { $+ } => { //~ ERROR expected identifier, found `+`
+        $(x)(y) //~ ERROR expected `*` or `+`
+                //~^ ERROR no rules expected the token `y`
+    }
+}