rustpkg: Address review comments from cmr

diff --git a/src/librustpkg/installed_packages.rs b/src/librustpkg/installed_packages.rs
index 2716cc5d5b59b4b2077646c8ee6fff03306d0dd4..980b00d3864d54102108e4129e926a93dfb07b4a 100644 (file)
--- a/src/librustpkg/installed_packages.rs
+++ b/src/librustpkg/installed_packages.rs
@@ -15,7 +15,7 @@
 
 pub fn list_installed_packages(f: &fn(&PkgId) -> bool) -> bool  {
     let workspaces = rust_path();
-    for workspaces.iter().advance() |p| {
+    for workspaces.iter().advance |p| {
         let binfiles = os::list_dir(&p.push("bin"));
         for binfiles.iter().advance() |exec| {
             f(&PkgId::new(*exec));
@@ -30,7 +30,7 @@ pub fn list_installed_packages(f: &fn(&PkgId) -> bool) -> bool  {
 
 pub fn package_is_installed(p: &PkgId) -> bool {
     let mut is_installed = false;
-    let _ = do list_installed_packages() |installed| {
+    do list_installed_packages() |installed| {
         if installed == p {
             is_installed = true;
         }

diff --git a/src/librustpkg/testsuite/pass/src/install-paths/main.rs b/src/librustpkg/testsuite/pass/src/install-paths/main.rs
index 3be03b6278bc500f24415bc52a73432973917dba..431350c07b487dbcdb31eefba84315d7568ee67f 100644 (file)
--- a/src/librustpkg/testsuite/pass/src/install-paths/main.rs
+++ b/src/librustpkg/testsuite/pass/src/install-paths/main.rs
@@ -24,5 +24,5 @@
 mod lib;
 
 fn main() {
-    let _ = f();
+    f();
 }