Address clippy lints

diff --git a/src/eval_context.rs b/src/eval_context.rs
index 2ae5fcf5cfe29ae849510470a8685b4aef68f036..28a08a8c209469abaeb65824e0b068886ade54b8 100644 (file)
--- a/src/eval_context.rs
+++ b/src/eval_context.rs
@@ -1285,9 +1285,9 @@ pub fn ty_to_primval_kind(&self, ty: Ty<'tcx>) -> EvalResult<'tcx, PrimValKind>
             ty::TyRef(_, ref tam) |
             ty::TyRawPtr(ref tam) if self.type_is_sized(tam.ty) => PrimValKind::Ptr,
 
-            ty::TyAdt(ref def, _) if def.is_box() => PrimValKind::Ptr,
+            ty::TyAdt(def, _) if def.is_box() => PrimValKind::Ptr,
 
-            ty::TyAdt(ref def, substs) => {
+            ty::TyAdt(def, substs) => {
                 use rustc::ty::layout::Layout::*;
                 match *self.type_layout(ty)? {
                     CEnum { discr, signed, .. } => {
@@ -1954,12 +1954,8 @@ pub fn needs_drop_glue<'a, 'tcx>(tcx: TyCtxt<'a, 'tcx, 'tcx>, t: Ty<'tcx>) -> bo
             if !typ.needs_drop(tcx, &env) && type_is_sized(tcx, typ) {
                 tcx.infer_ctxt((), traits::Reveal::All).enter(|infcx| {
                     let layout = t.layout(&infcx).unwrap();
-                    if layout.size(&tcx.data_layout).bytes() == 0 {
-                        // `Box<ZeroSizeType>` does not allocate.
-                        false
-                    } else {
-                        true
-                    }
+                    // `Box<ZeroSizeType>` does not allocate.
+                    layout.size(&tcx.data_layout).bytes() != 0
                 })
             } else {
                 true

diff --git a/src/lvalue.rs b/src/lvalue.rs
index 45d9501458d7bc476d419768589c663f509197f6..0f1ce103b0c44f702e133d81c2e6166e22125a21 100644 (file)
--- a/src/lvalue.rs
+++ b/src/lvalue.rs
@@ -322,7 +322,7 @@ fn eval_lvalue_projection(
                 let pointee_type = match base_ty.sty {
                     ty::TyRawPtr(ref tam) |
                     ty::TyRef(_, ref tam) => tam.ty,
-                    ty::TyAdt(ref def, _) if def.is_box() => base_ty.boxed_ty(),
+                    ty::TyAdt(def, _) if def.is_box() => base_ty.boxed_ty(),
                     _ => bug!("can only deref pointer types"),
                 };
 

diff --git a/src/memory.rs b/src/memory.rs
index 3d46d710d3dd7501fd7ed5d910affc36045f0de0..f2440d3d7267297f8ef26dfcb4aada5ef3dcc513 100644 (file)
--- a/src/memory.rs
+++ b/src/memory.rs
@@ -202,7 +202,7 @@ pub fn allocate(&mut self, size: u64, align: u64) -> EvalResult<'tcx, Pointer> {
         if size == 0 {
             return Ok(Pointer::zst_ptr());
         }
-        assert!(align != 0);
+        assert_ne!(align, 0);
 
         if self.memory_size - self.memory_usage < size {
             return Err(EvalError::OutOfMemory {

diff --git a/src/terminator/mod.rs b/src/terminator/mod.rs
index 03804ccd0bd5137e920cd66dcc6f1a1f3f9a9f88..0c0239f592695b529ba269a1efdd14d256ce5db1 100644 (file)
--- a/src/terminator/mod.rs
+++ b/src/terminator/mod.rs
@@ -298,7 +298,7 @@ fn eval_fn_call(
                 let pointee_type = match ty.sty {
                     ty::TyRawPtr(ref tam) |
                     ty::TyRef(_, ref tam) => tam.ty,
-                    ty::TyAdt(ref def, _) if def.is_box() => ty.boxed_ty(),
+                    ty::TyAdt(def, _) if def.is_box() => ty.boxed_ty(),
                     _ => bug!("can only deref pointer types"),
                 };
                 self.drop(val, instance, pointee_type, span)