error: defining a method called `add` on this type; consider implementing the `std::ops::Add` trait or choosing a less ambiguous name
- --> $DIR/methods.rs:35:5
+ --> $DIR/methods.rs:36:5
|
LL | / pub fn add(self, other: T) -> T {
LL | | self
|
= note: `-D clippy::should-implement-trait` implied by `-D warnings`
-error: methods called `into_*` usually take self by value; consider choosing a less ambiguous name
- --> $DIR/methods.rs:70:17
- |
-LL | fn into_u16(&self) -> u16 {
- | ^^^^^
- |
- = note: `-D clippy::wrong-self-convention` implied by `-D warnings`
-
-error: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
- --> $DIR/methods.rs:74:21
- |
-LL | fn to_something(self) -> u32 {
- | ^^^^
-
-error: methods called `new` usually take no self; consider choosing a less ambiguous name
- --> $DIR/methods.rs:78:12
- |
-LL | fn new(self) -> Self {
- | ^^^^
-
error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead
- --> $DIR/methods.rs:157:13
+ --> $DIR/methods.rs:158:13
|
LL | let _ = opt.map(|x| x + 1)
| _____________^
= note: replace `map(|x| x + 1).unwrap_or(0)` with `map_or(0, |x| x + 1)`
error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead
- --> $DIR/methods.rs:161:13
+ --> $DIR/methods.rs:162:13
|
LL | let _ = opt.map(|x| {
| _____________^
| |____________________________^
error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead
- --> $DIR/methods.rs:165:13
+ --> $DIR/methods.rs:166:13
|
LL | let _ = opt.map(|x| x + 1)
| _____________^
| |__________________^
error: called `map(f).unwrap_or(None)` on an Option value. This can be done more directly by calling `and_then(f)` instead
- --> $DIR/methods.rs:170:13
+ --> $DIR/methods.rs:171:13
|
LL | let _ = opt.map(|x| Some(x + 1)).unwrap_or(None);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= note: replace `map(|x| Some(x + 1)).unwrap_or(None)` with `and_then(|x| Some(x + 1))`
error: called `map(f).unwrap_or(None)` on an Option value. This can be done more directly by calling `and_then(f)` instead
- --> $DIR/methods.rs:172:13
+ --> $DIR/methods.rs:173:13
|
LL | let _ = opt.map(|x| {
| _____________^
| |_____________________^
error: called `map(f).unwrap_or(None)` on an Option value. This can be done more directly by calling `and_then(f)` instead
- --> $DIR/methods.rs:176:13
+ --> $DIR/methods.rs:177:13
|
LL | let _ = opt
| _____________^
= note: replace `map(|x| Some(x + 1)).unwrap_or(None)` with `and_then(|x| Some(x + 1))`
error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead
- --> $DIR/methods.rs:187:13
+ --> $DIR/methods.rs:188:13
|
LL | let _ = Some("prefix").map(|p| format!("{}.", p)).unwrap_or(id);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= note: replace `map(|p| format!("{}.", p)).unwrap_or(id)` with `map_or(id, |p| format!("{}.", p))`
error: called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead
- --> $DIR/methods.rs:191:13
+ --> $DIR/methods.rs:192:13
|
LL | let _ = opt.map(|x| x + 1)
| _____________^
= note: replace `map(|x| x + 1).unwrap_or_else(|| 0)` with `map_or_else(|| 0, |x| x + 1)`
error: called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead
- --> $DIR/methods.rs:195:13
+ --> $DIR/methods.rs:196:13
|
LL | let _ = opt.map(|x| {
| _____________^
| |____________________________________^
error: called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead
- --> $DIR/methods.rs:199:13
+ --> $DIR/methods.rs:200:13
|
LL | let _ = opt.map(|x| x + 1)
| _____________^
| |_________________^
error: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
- --> $DIR/methods.rs:229:13
+ --> $DIR/methods.rs:230:13
|
LL | let _ = v.iter().filter(|&x| *x < 0).next();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= note: replace `filter(|&x| *x < 0).next()` with `find(|&x| *x < 0)`
error: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
- --> $DIR/methods.rs:232:13
+ --> $DIR/methods.rs:233:13
|
LL | let _ = v.iter().filter(|&x| {
| _____________^
| |___________________________^
error: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
- --> $DIR/methods.rs:248:13
+ --> $DIR/methods.rs:249:13
|
LL | let _ = v.iter().find(|&x| *x < 0).is_some();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= note: replace `find(|&x| *x < 0).is_some()` with `any(|x| *x < 0)`
error: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
- --> $DIR/methods.rs:251:13
+ --> $DIR/methods.rs:252:13
|
LL | let _ = v.iter().find(|&x| {
| _____________^
| |______________________________^
error: called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`.
- --> $DIR/methods.rs:257:13
+ --> $DIR/methods.rs:258:13
|
LL | let _ = v.iter().position(|&x| x < 0).is_some();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= note: replace `position(|&x| x < 0).is_some()` with `any(|&x| x < 0)`
error: called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`.
- --> $DIR/methods.rs:260:13
+ --> $DIR/methods.rs:261:13
|
LL | let _ = v.iter().position(|&x| {
| _____________^
| |______________________________^
error: called `is_some()` after searching an `Iterator` with rposition. This is more succinctly expressed by calling `any()`.
- --> $DIR/methods.rs:266:13
+ --> $DIR/methods.rs:267:13
|
LL | let _ = v.iter().rposition(|&x| x < 0).is_some();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= note: replace `rposition(|&x| x < 0).is_some()` with `any(|&x| x < 0)`
error: called `is_some()` after searching an `Iterator` with rposition. This is more succinctly expressed by calling `any()`.
- --> $DIR/methods.rs:269:13
+ --> $DIR/methods.rs:270:13
|
LL | let _ = v.iter().rposition(|&x| {
| _____________^
| |______________________________^
error: used unwrap() on an Option value. If you don't want to handle the None case gracefully, consider using expect() to provide a better panic message
- --> $DIR/methods.rs:284:13
+ --> $DIR/methods.rs:285:13
|
LL | let _ = opt.unwrap();
| ^^^^^^^^^^^^
|
= note: `-D clippy::option-unwrap-used` implied by `-D warnings`
-error: aborting due to 23 previous errors
+error: aborting due to 20 previous errors