Reduce code duplication

diff --git a/clippy_lints/src/misc.rs b/clippy_lints/src/misc.rs
index c2fc932a67856a2c81bf67fc70f0ee92d555f8b3..3a202c189ec2e123a24bda39fcad6c28725d8f21 100644 (file)
--- a/clippy_lints/src/misc.rs
+++ b/clippy_lints/src/misc.rs
@@ -456,26 +456,16 @@ fn check_to_owned(cx: &LateContext, expr: &Expr, other: &Expr, left: bool, op: S
         return;
     }
 
-    if left {
-        span_lint(cx,
-                  CMP_OWNED,
-                  expr.span,
-                  &format!("this creates an owned instance just for comparison. Consider using `{} {} {}` to \
-                            compare without allocation",
-                           snip,
-                           snippet(cx, op, "=="),
-                           snippet(cx, other.span, "..")));
-    } else {
-        span_lint(cx,
-                  CMP_OWNED,
-                  expr.span,
-                  &format!("this creates an owned instance just for comparison. Consider using `{} {} {}` to \
-                            compare without allocation",
-                           snippet(cx, other.span, ".."),
-                           snippet(cx, op, "=="),
-                           snip));
-    }
-
+    let other = snippet(cx, other.span, "..");
+    let (snip, other) = if left { (snip, other) } else { (other, snip) };
+    span_lint(cx,
+                CMP_OWNED,
+                expr.span,
+                &format!("this creates an owned instance just for comparison. Consider using `{} {} {}` to \
+                        compare without allocation",
+                        snip,
+                        snippet(cx, op, "=="),
+                        other));
 }
 
 fn is_str_arg(cx: &LateContext, args: &[Expr]) -> bool {