]> git.lizzy.rs Git - rust.git/commitdiff
Merge #7116
authorbors[bot] <26634292+bors[bot]@users.noreply.github.com>
Fri, 1 Jan 2021 11:06:27 +0000 (11:06 +0000)
committerGitHub <noreply@github.com>
Fri, 1 Jan 2021 11:06:27 +0000 (11:06 +0000)
7116: Fix deep syntax tree bug generated by proc-macro r=jonas-schievink a=edwin0cheng

This PR fixed a bug from `semver-parser` and `pest_derive` crates which generate a very deep syntax tree such that serde reject to de-serialize. To fix this bug, we disabled recursion limit in `serde` (by calling [`Deserializer::disable_recursion_limit`](https://docs.rs/serde_json/1.0.61/serde_json/struct.Deserializer.html#method.disable_recursion_limit))

I have a feeling that we still need some way to protect against bad proc-macro generating huge syntax node, but I have no  idea right now.

r? @jonas-schievink

Fixes #7103

Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>

Trivial merge