]> git.lizzy.rs Git - rust.git/commitdiff
undo some tweaks to build_impl
authorQuietMisdreavus <grey@quietmisdreavus.net>
Tue, 14 Aug 2018 19:41:07 +0000 (14:41 -0500)
committerQuietMisdreavus <grey@quietmisdreavus.net>
Thu, 20 Sep 2018 10:42:26 +0000 (05:42 -0500)
src/librustdoc/clean/inline.rs

index 8b4495a5eff451d1087fc2b1c751a9774eff32dd..74e9f5b8a203ec1a3b750805a65febfbaa3974fe 100644 (file)
@@ -296,7 +296,6 @@ pub fn build_impls(cx: &DocContext, did: DefId, auto_traits: bool) -> Vec<clean:
 
 pub fn build_impl(cx: &DocContext, did: DefId, ret: &mut Vec<clean::Item>) {
     if !cx.renderinfo.borrow_mut().inlined.insert(did) {
-        debug!("already inlined, bailing: {:?}", did);
         return
     }
 
@@ -306,12 +305,9 @@ pub fn build_impl(cx: &DocContext, did: DefId, ret: &mut Vec<clean::Item>) {
 
     // Only inline impl if the implemented trait is
     // reachable in rustdoc generated documentation
-    if !did.is_local() {
-        if let Some(traitref) = associated_trait {
-            if !cx.access_levels.borrow().is_doc_reachable(traitref.def_id) {
-                debug!("trait {:?} not reachable, bailing: {:?}", traitref.def_id, did);
-                return
-            }
+    if let Some(traitref) = associated_trait {
+        if !cx.access_levels.borrow().is_doc_reachable(traitref.def_id) {
+            return
         }
     }
 
@@ -319,12 +315,9 @@ pub fn build_impl(cx: &DocContext, did: DefId, ret: &mut Vec<clean::Item>) {
 
     // Only inline impl if the implementing type is
     // reachable in rustdoc generated documentation
-    if !did.is_local() {
-        if let Some(did) = for_.def_id() {
-            if !cx.access_levels.borrow().is_doc_reachable(did) {
-                debug!("impl type {:?} not accessible, bailing", did);
-                return
-            }
+    if let Some(did) = for_.def_id() {
+        if !cx.access_levels.borrow().is_doc_reachable(did) {
+            return
         }
     }
 
@@ -357,6 +350,8 @@ pub fn build_impl(cx: &DocContext, did: DefId, ret: &mut Vec<clean::Item>) {
            .collect()
     }).unwrap_or(FxHashSet());
 
+    debug!("build_impl: impl {:?} for {:?}", trait_.def_id(), for_.def_id());
+
     ret.push(clean::Item {
         inner: clean::ImplItem(clean::Impl {
             unsafety: hir::Unsafety::Normal,