Forbid associated items in inherent impls

Closes #20359

diff --git a/src/librustc_typeck/collect.rs b/src/librustc_typeck/collect.rs
index 79e98f15a2d43daf7a4a609886f632debf61542e..5852a34560c9f75ee03d16f57530bc194fcddec8 100644 (file)
--- a/src/librustc_typeck/collect.rs
+++ b/src/librustc_typeck/collect.rs
@@ -607,6 +607,11 @@ fn convert(ccx: &CollectCtxt, it: &ast::Item) {
                         methods.push(&**method);
                     }
                     ast::TypeImplItem(ref typedef) => {
+                        if opt_trait_ref.is_none() {
+                            tcx.sess.span_err(typedef.span,
+                                              "associated items are not allowed in inherent impls");
+                        }
+
                         let typ = ccx.to_ty(&ExplicitRscope, &*typedef.typ);
                         tcx.tcache
                            .borrow_mut()

diff --git a/src/test/compile-fail/assoc-inherent.rs b/src/test/compile-fail/assoc-inherent.rs
new file mode 100644 (file)
index 0000000..8025011
--- /dev/null
+++ b/src/test/compile-fail/assoc-inherent.rs
@@ -0,0 +1,19 @@
+// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
+// file at the top-level directory of this distribution and at
+// http://rust-lang.org/COPYRIGHT.
+//
+// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
+// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
+// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
+// option. This file may not be copied, modified, or distributed
+// except according to those terms.
+
+// Test associated types are forbidden in inherant impls.
+
+struct Foo;
+
+impl Foo {
+    type Bar = int; //~ERROR associated items are not allowed in inherent impls
+}
+
+fn main() {}