In trans, allow _|_-typed things to be the argument to fail

Rationale: _|_-typed things diverge, so it's safe to use them in
any context.

Closes #1465

diff --git a/src/comp/middle/trans.rs b/src/comp/middle/trans.rs
index c519461887dc7f1ea026baccd241ebf451c49122..92a37ab36d912c76a02375ed46eb6256555ba22f 100644 (file)
--- a/src/comp/middle/trans.rs
+++ b/src/comp/middle/trans.rs
@@ -3775,7 +3775,7 @@ fn trans_fail_expr(bcx: @block_ctxt, sp_opt: option::t<span>,
                 bcx, expr_res.val, type_of_or_i8(
                     bcx, ty::mk_mach_uint(tcx, ast::ty_u8)));
             ret trans_fail_value(bcx, sp_opt, data);
-        } else if bcx.unreachable {
+        } else if bcx.unreachable || ty::type_is_bot(tcx, e_ty) {
             ret bcx;
         } else {
             bcx_ccx(bcx).sess.span_bug(

diff --git a/src/test/run-fail/do-while-fail.rs b/src/test/run-fail/do-while-fail.rs
new file mode 100644 (file)
index 0000000..38c6d38
--- /dev/null
+++ b/src/test/run-fail/do-while-fail.rs
@@ -0,0 +1,4 @@
+// error-pattern:giraffe
+fn main() {
+  fail do { fail "giraffe" } while true;
+}