]> git.lizzy.rs Git - rust.git/commitdiff
std::rt::backtrace: Fix symbol names on Windows
authorklutzy <klutzytheklutzy@gmail.com>
Sun, 21 Sep 2014 16:25:57 +0000 (01:25 +0900)
committerklutzy <klutzytheklutzy@gmail.com>
Sun, 21 Sep 2014 16:42:28 +0000 (01:42 +0900)
Fixes #17372

src/libstd/rt/backtrace.rs

index f4887a143d1dc74ce721264384caa3711898c44b..de5c26e03a3b32e27bd6fb2fe4002fef83953ba0 100644 (file)
@@ -701,7 +701,7 @@ mod imp {
     static IMAGE_FILE_MACHINE_IA64: libc::DWORD = 0x0200;
     static IMAGE_FILE_MACHINE_AMD64: libc::DWORD = 0x8664;
 
-    #[repr(C, packed)]
+    #[repr(C)]
     struct SYMBOL_INFO {
         SizeOfStruct: libc::c_ulong,
         TypeIndex: libc::c_ulong,
@@ -983,8 +983,10 @@ macro_rules! sym( ($e:expr, $t:ident) => (unsafe {
             try!(write!(w, "  {:2}: {:#2$x}", i, addr, super::HEX_WIDTH));
             let mut info: SYMBOL_INFO = unsafe { intrinsics::init() };
             info.MaxNameLen = MAX_SYM_NAME as libc::c_ulong;
-            info.SizeOfStruct = (mem::size_of::<SYMBOL_INFO>() -
-                                 info.Name.len() + 1) as libc::c_ulong;
+            // the struct size in C.  the value is different to
+            // `size_of::<SYMBOL_INFO>() - MAX_SYM_NAME + 1` (== 81)
+            // due to struct alignment.
+            info.SizeOfStruct = 88;
 
             let mut displacement = 0u64;
             let ret = SymFromAddr(process, addr as u64, &mut displacement,