]> git.lizzy.rs Git - rust.git/commitdiff
query: faster stack reversal in remove_cycle
authorljedrz <ljedrz@gmail.com>
Wed, 19 Dec 2018 12:08:17 +0000 (13:08 +0100)
committerljedrz <ljedrz@gmail.com>
Wed, 19 Dec 2018 12:08:17 +0000 (13:08 +0100)
src/librustc/ty/query/job.rs

index 1439e41bb31fd9ba5924683d19947288f657be9a..2e6cd8e0ec3d90ba79008218484c13bcae50cf56 100644 (file)
@@ -390,11 +390,9 @@ fn remove_cycle<'tcx>(
                                       DUMMY_SP,
                                       &mut stack,
                                       &mut visited) {
-        // Reverse the stack so earlier entries require later entries
-        stack.reverse();
-
-        // The stack is a vector of pairs of spans and queries
-        let (mut spans, queries): (Vec<_>, Vec<_>) = stack.into_iter().unzip();
+        // The stack is a vector of pairs of spans and queries; reverse it so that
+        // the earlier entries require later entries
+        let (mut spans, queries): (Vec<_>, Vec<_>) = stack.into_iter().rev().unzip();
 
         // Shift the spans so that queries are matched with the span for their waitee
         spans.rotate_right(1);