## Lints
-There are 161 lints included in this crate:
+There are 162 lints included in this crate:
name | default | meaning
---------------------------------------------------------------------------------------------------------------------|---------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
[unnecessary_operation](https://github.com/Manishearth/rust-clippy/wiki#unnecessary_operation) | warn | outer expressions with no effect
[unneeded_field_pattern](https://github.com/Manishearth/rust-clippy/wiki#unneeded_field_pattern) | warn | Struct fields are bound to a wildcard instead of using `..`
[unsafe_removed_from_name](https://github.com/Manishearth/rust-clippy/wiki#unsafe_removed_from_name) | warn | unsafe removed from name
+[unseparated_literal_suffix](https://github.com/Manishearth/rust-clippy/wiki#unseparated_literal_suffix) | allow | literal suffixes should be separated with an underscore
[unused_collect](https://github.com/Manishearth/rust-clippy/wiki#unused_collect) | warn | `collect()`ing an iterator without using the result; this is usually better written as a for loop
[unused_label](https://github.com/Manishearth/rust-clippy/wiki#unused_label) | warn | unused label
[unused_lifetimes](https://github.com/Manishearth/rust-clippy/wiki#unused_lifetimes) | warn | unused lifetimes in function definitions
use rustc::lint::*;
use std::collections::HashMap;
+use std::char;
use syntax::ast::*;
use syntax::codemap::Span;
use syntax::visit::FnKind;
"letter digits in hex literals should be either completely upper- or lowercased"
}
+/// **What it does:** Warns if literal suffixes are not separated by an underscore.
+///
+/// **Why is this bad?** It is much less readable.
+///
+/// **Known problems:** None.
+///
+/// **Example:**
+/// ```rust
+/// let y = 123832i32;
+/// ```
+declare_lint! {
+ pub UNSEPARATED_LITERAL_SUFFIX, Allow,
+ "literal suffixes should be separated with an underscore"
+}
+
#[derive(Copy, Clone)]
pub struct MiscEarly;
impl LintPass for MiscEarly {
fn get_lints(&self) -> LintArray {
lint_array!(UNNEEDED_FIELD_PATTERN, DUPLICATE_UNDERSCORE_ARGUMENT, REDUNDANT_CLOSURE_CALL,
- DOUBLE_NEG, MIXED_CASE_HEX_LITERALS)
+ DOUBLE_NEG, MIXED_CASE_HEX_LITERALS, UNSEPARATED_LITERAL_SUFFIX)
}
}
if_let_chain! {[
let LitKind::Int(..) = lit.node,
let Some(src) = snippet_opt(cx, lit.span),
- src.starts_with("0x")
+ let Some(firstch) = src.chars().next(),
+ char::to_digit(firstch, 10).is_some()
], {
- let mut seen = (false, false);
+ let mut prev = '\0';
for ch in src.chars() {
- match ch {
- 'a' ... 'f' => seen.0 = true,
- 'A' ... 'F' => seen.1 = true,
- 'i' | 'u' => break, // start of suffix already
- _ => ()
+ if ch == 'i' || ch == 'u' {
+ if prev != '_' {
+ span_lint(cx, UNSEPARATED_LITERAL_SUFFIX, lit.span,
+ "integer type suffix should be separated by an underscore");
+ }
+ break;
}
+ prev = ch;
}
- if seen.0 && seen.1 {
- span_lint(cx, MIXED_CASE_HEX_LITERALS, lit.span,
- "inconsistent casing in hexadecimal literal");
+ if src.starts_with("0x") {
+ let mut seen = (false, false);
+ for ch in src.chars() {
+ match ch {
+ 'a' ... 'f' => seen.0 = true,
+ 'A' ... 'F' => seen.1 = true,
+ 'i' | 'u' => break, // start of suffix already
+ _ => ()
+ }
+ }
+ if seen.0 && seen.1 {
+ span_lint(cx, MIXED_CASE_HEX_LITERALS, lit.span,
+ "inconsistent casing in hexadecimal literal");
+ }
+ }
+ }}
+ if_let_chain! {[
+ let LitKind::Float(..) = lit.node,
+ let Some(src) = snippet_opt(cx, lit.span),
+ let Some(firstch) = src.chars().next(),
+ char::to_digit(firstch, 10).is_some()
+ ], {
+ let mut prev = '\0';
+ for ch in src.chars() {
+ if ch == 'f' {
+ if prev != '_' {
+ span_lint(cx, UNSEPARATED_LITERAL_SUFFIX, lit.span,
+ "float type suffix should be separated by an underscore");
+ }
+ break;
+ }
+ prev = ch;
}
}}
}
.map(|x| x * 2)
.collect();
- let _: Vec<_> = vec![5i8; 6].into_iter() //~ERROR called `filter(p).flat_map(q)` on an `Iterator`
+ let _: Vec<_> = vec![5_i8; 6].into_iter() //~ERROR called `filter(p).flat_map(q)` on an `Iterator`
.filter(|&x| x == 0)
.flat_map(|x| x.checked_mul(2))
.collect();
- let _: Vec<_> = vec![5i8; 6].into_iter() //~ERROR called `filter_map(p).flat_map(q)` on an `Iterator`
+ let _: Vec<_> = vec![5_i8; 6].into_iter() //~ERROR called `filter_map(p).flat_map(q)` on an `Iterator`
.filter_map(|x| x.checked_mul(2))
.flat_map(|x| x.checked_mul(2))
.collect();
- let _: Vec<_> = vec![5i8; 6].into_iter() //~ERROR called `filter_map(p).map(q)` on an `Iterator`
+ let _: Vec<_> = vec![5_i8; 6].into_iter() //~ERROR called `filter_map(p).map(q)` on an `Iterator`
.filter_map(|x| x.checked_mul(2))
.map(|x| x.checked_mul(2))
.collect();
#![feature(plugin)]
#![plugin(clippy)]
#![deny(mixed_case_hex_literals)]
+#![deny(unseparated_literal_suffix)]
#![allow(dead_code)]
fn main() {
let fail1 = 0xabCD; //~ERROR inconsistent casing in hexadecimal literal
let fail2 = 0xabCD_u32; //~ERROR inconsistent casing in hexadecimal literal
let fail2 = 0xabCD_isize; //~ERROR inconsistent casing in hexadecimal literal
+
+ let ok6 = 1234_i32;
+ let ok7 = 1234_f32;
+ let ok8 = 1234_isize;
+ let fail3 = 1234i32; //~ERROR integer type suffix should be separated
+ let fail4 = 1234u32; //~ERROR integer type suffix should be separated
+ let fail5 = 1234isize; //~ERROR integer type suffix should be separated
+ let fail6 = 1234usize; //~ERROR integer type suffix should be separated
+ let fail7 = 1.5f32; //~ERROR float type suffix should be separated
}
projects / rust.git / commitdiff