]> git.lizzy.rs Git - rust.git/commitdiff
lint: deny incoherent_fundamental_impls by default
authorHoàng Đức Hiếu <hdhoang@hdhoang.space>
Wed, 2 May 2018 07:32:32 +0000 (14:32 +0700)
committerHoàng Đức Hiếu <hdhoang@hdhoang.space>
Wed, 2 May 2018 10:30:26 +0000 (17:30 +0700)
Warn the ecosystem of the pending intent-to-disallow in #49799.

src/librustc/lint/builtin.rs
src/test/compile-fail/issue-43355.rs
src/test/run-pass/issue-43355.rs [deleted file]

index 109edffcde38a5d3cc9a22804c6b6e3b47ed5d7f..2bc31b00eb73bec483a97112aca5156b2dcc0681 100644 (file)
 
 declare_lint! {
     pub INCOHERENT_FUNDAMENTAL_IMPLS,
-    Warn,
+    Deny,
     "potentially-conflicting impls were erroneously allowed"
 }
 
index 4db5c84df9a63d6f43d170da9fccb52170f8da00..d793a78799a70714ef6d1d832aa1c78eed34f8d6 100644 (file)
@@ -8,8 +8,6 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-#![deny(incoherent_fundamental_impls)]
-
 pub trait Trait1<X> {
     type Output;
 }
diff --git a/src/test/run-pass/issue-43355.rs b/src/test/run-pass/issue-43355.rs
deleted file mode 100644 (file)
index 19431a6..0000000
+++ /dev/null
@@ -1,36 +0,0 @@
-// Copyright 2017 The Rust Project Developers. See the COPYRIGHT
-// file at the top-level directory of this distribution and at
-// http://rust-lang.org/COPYRIGHT.
-//
-// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
-// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
-// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
-// option. This file may not be copied, modified, or distributed
-// except according to those terms.
-
-// Check that the code for issue #43355 can run without an ICE, please remove
-// this test when it becomes an hard error.
-
-pub trait Trait1<X> {
-    type Output;
-}
-pub trait Trait2<X> {}
-
-impl<X, T> Trait1<X> for T where T: Trait2<X> {
-    type Output = ();
-}
-impl<X> Trait1<Box<X>> for A {
-    type Output = i32;
-}
-
-pub struct A;
-
-fn f<X, T: Trait1<Box<X>>>() {
-    println!("k: {}", ::std::mem::size_of::<<T as Trait1<Box<X>>>::Output>());
-}
-
-pub fn g<X, T: Trait2<Box<X>>>() {
-    f::<X, T>();
-}
-
-fn main() {}