Make search results tab and help button focusable with keyboard

diff --git a/src/librustdoc/html/layout.rs b/src/librustdoc/html/layout.rs
index e8039942f4f8325a0374bd917fb53ce00afcd3b4..f2c74c46d7db8febadcc4a199011d00f2fc94287 100644 (file)
--- a/src/librustdoc/html/layout.rs
+++ b/src/librustdoc/html/layout.rs
@@ -98,7 +98,7 @@
                            placeholder=\"Click or press ‘S’ to search, ‘?’ for more options…\" \
                            type=\"search\">\
                 </div>\
-                <span class=\"help-button\">?</span>
+                <button class=\"help-button\">?</button>
                 <a id=\"settings-menu\" href=\"{root_path}settings.html\">\
                     <img src=\"{static_root_path}wheel{suffix}.svg\" \
                          width=\"18\" \

diff --git a/src/librustdoc/html/static/main.js b/src/librustdoc/html/static/main.js
index a0ccb078c4a3ee5ab71976e303055c29234e3f79..47847ccb5f615f5ee4a7680e221a6bb0663be7d7 100644 (file)
--- a/src/librustdoc/html/static/main.js
+++ b/src/librustdoc/html/static/main.js
@@ -1633,10 +1633,10 @@ function defocusSearchBar() {
 
         function makeTabHeader(tabNb, text, nbElems) {
             if (currentTab === tabNb) {
-                return "<div class=\"selected\">" + text +
-                       " <div class=\"count\">(" + nbElems + ")</div></div>";
+                return "<button class=\"selected\">" + text +
+                       " <div class=\"count\">(" + nbElems + ")</div></button>";
             }
-            return "<div>" + text + " <div class=\"count\">(" + nbElems + ")</div></div>";
+            return "<button>" + text + " <div class=\"count\">(" + nbElems + ")</div></button>";
         }
 
         function showResults(results) {

diff --git a/src/librustdoc/html/static/rustdoc.css b/src/librustdoc/html/static/rustdoc.css
index 8eef65a231d0be7c9cc31b935c554b9cb8c92c66..61905b8eca8b694dfdc308b1d566149176473563 100644 (file)
--- a/src/librustdoc/html/static/rustdoc.css
+++ b/src/librustdoc/html/static/rustdoc.css
@@ -1176,21 +1176,22 @@ pre.rust {
        height: 35px;
 }
 
-#titles > div {
+#titles > button {
        float: left;
        width: 33.3%;
        text-align: center;
        font-size: 18px;
        cursor: pointer;
+       border: 0;
        border-top: 2px solid;
 }
 
-#titles > div:not(:last-child) {
+#titles > button:not(:last-child) {
        margin-right: 1px;
        width: calc(33.3% - 1px);
 }
 
-#titles > div > div.count {
+#titles > button > div.count {
        display: inline-block;
        font-size: 16px;
 }
@@ -1459,7 +1460,7 @@ h4 > .notable-traits {
                top: 24px;
        }
 
-       #titles > div > div.count {
+       #titles > button > div.count {
                float: left;
                width: 100%;
        }
@@ -1565,7 +1566,7 @@ h4 > .notable-traits {
 }
 
 @media (max-width: 416px) {
-       #titles, #titles > div {
+       #titles, #titles > button {
                height: 73px;
        }
 

diff --git a/src/librustdoc/html/static/themes/ayu.css b/src/librustdoc/html/static/themes/ayu.css
index c1f796f09e80474a453e2c3ab573ed978a58c5b7..76bbe4f6201939103af39b4124a3195f881cb4f9 100644 (file)
--- a/src/librustdoc/html/static/themes/ayu.css
+++ b/src/librustdoc/html/static/themes/ayu.css
@@ -403,22 +403,22 @@ pre.ignore:hover, .information:hover + pre.ignore {
        border-color: #5c6773;
 }
 
-#titles > div.selected {
+#titles > button.selected {
        background-color: #141920 !important;
        border-bottom: 1px solid #ffb44c !important;
        border-top: none;
 }
 
-#titles > div:not(.selected) {
+#titles > button:not(.selected) {
        background-color: transparent !important;
        border: none;
 }
 
-#titles > div:hover {
+#titles > button:hover {
        border-bottom: 1px solid rgba(242, 151, 24, 0.3);
 }
 
-#titles > div > div.count {
+#titles > button > div.count {
        color: #888;
 }
 
@@ -434,7 +434,7 @@ above the `@media (max-width: 700px)` rules due to a bug in the css checker */
 .block a.current.derive,.content span.macro,.content a.macro,.block a.current.macro {}
 .content .highlighted.trait {}
 .content span.struct,.content a.struct,.block a.current.struct {}
-#titles>div:hover,#titles>div.selected {}
+#titles>button:hover,#titles>button.selected {}
 .content .highlighted.traitalias {}
 .content span.type,.content a.type,.block a.current.type {}
 .content span.union,.content a.union,.block a.current.union {}

diff --git a/src/librustdoc/html/static/themes/dark.css b/src/librustdoc/html/static/themes/dark.css
index 946ca0a40c9dc9595ed610113ada880970caa86d..86ce99284eba8e3c9ece3e536639106c3e5d220c 100644 (file)
--- a/src/librustdoc/html/static/themes/dark.css
+++ b/src/librustdoc/html/static/themes/dark.css
@@ -352,16 +352,17 @@ pre.ignore:hover, .information:hover + pre.ignore {
        border-color: #777;
 }
 
-#titles > div:not(.selected) {
+#titles > button:not(.selected) {
        background-color: #252525;
        border-top-color: #252525;
 }
 
-#titles > div:hover, #titles > div.selected {
+#titles > button:hover, #titles > button.selected {
        border-top-color: #0089ff;
+       background-color: #353535;
 }
 
-#titles > div > div.count {
+#titles > button > div.count {
        color: #888;
 }
 

diff --git a/src/librustdoc/html/static/themes/light.css b/src/librustdoc/html/static/themes/light.css
index e0b9a04921a80561ca7d9e045c81adcc7d5f0181..52cfdf6f7a38ac424613a4a3f84a24994843847c 100644 (file)
--- a/src/librustdoc/html/static/themes/light.css
+++ b/src/librustdoc/html/static/themes/light.css
@@ -343,16 +343,17 @@ pre.ignore:hover, .information:hover + pre.ignore {
        border-color: #999;
 }
 
-#titles > div:not(.selected) {
+#titles > button:not(.selected) {
        background-color: #e6e6e6;
        border-top-color: #e6e6e6;
 }
 
-#titles > div:hover, #titles > div.selected {
+#titles > button:hover, #titles > button.selected {
        border-top-color: #0089ff;
+       background-color: #353535;
 }
 
-#titles > div > div.count {
+#titles > button > div.count {
        color: #888;
 }