]> git.lizzy.rs Git - rust.git/commitdiff
Auto merge of #9705 - jntrnr:disable_needless_collect, r=Manishearth
authorbors <bors@rust-lang.org>
Mon, 7 Nov 2022 17:08:10 +0000 (17:08 +0000)
committerbors <bors@rust-lang.org>
Mon, 7 Nov 2022 17:08:10 +0000 (17:08 +0000)
Move needless_collect to nursery

*Please write a short comment explaining your change (or "none" for internal only changes)*

changelog: [`needless_collect`]: Move `needless_collect` to nursery (Now allow-by-default)

After chatting with a few folks, it seems like `needless_collect` is giving false positives pretty regularly (https://github.com/rust-lang/rust-clippy/issues?q=is%3Aissue+is%3Aopen+needless_collect). We're big supporters of clippy in Nushell, and it's one of the passes we require for CI, but we've had to disable this particular lint. Perhaps it should be moved to the nursery until it's improved?

(apologies if this isn't the right approach to disabling a lint by default. I tried to follow the idea I saw other PRs doing in the past)


Trivial merge