There is no longer a need for that pattern, since enums are now qualified.
use syntax::ast::{Block, FnDecl, NodeId};
use syntax::ast;
use syntax::codemap::Span;
-use syntax::visit;
+use syntax::visit::FnKind;
/// An FnLikeNode is a Node that is like a fn, in that it has a decl
/// and a body (as well as a NodeId, a span, etc).
pub struct FnParts<'a> {
pub decl: &'a FnDecl,
pub body: &'a Block,
- pub kind: visit::FnKind<'a>,
+ pub kind: FnKind<'a>,
pub span: Span,
pub id: NodeId,
}
|c: ClosureParts| c.id)
}
- pub fn kind(self) -> visit::FnKind<'a> {
- let item = |p: ItemFnParts<'a>| -> visit::FnKind<'a> {
- visit::FkItemFn(p.ident, p.generics, p.unsafety, p.constness, p.abi, p.vis)
+ pub fn kind(self) -> FnKind<'a> {
+ let item = |p: ItemFnParts<'a>| -> FnKind<'a> {
+ FnKind::ItemFn(p.ident, p.generics, p.unsafety, p.constness, p.abi, p.vis)
};
let closure = |_: ClosureParts| {
- visit::FkClosure
+ FnKind::Closure
};
let method = |_, ident, sig: &'a ast::MethodSig, vis, _, _| {
- visit::FkMethod(ident, sig, vis)
+ FnKind::Method(ident, sig, vis)
};
self.handle(item, method, closure)
}
use syntax::ast;
use syntax::codemap::Span;
-use syntax::visit::{self, Visitor};
+use syntax::visit::{self, FnKind, Visitor};
use std::collections::hash_map::Entry;
use std::cmp::Ordering;
}
fn fn_like(&mut self,
- fk: visit::FnKind,
+ fk: FnKind,
fd: &ast::FnDecl,
b: &ast::Block,
s: Span,
}
let mode = match fk {
- visit::FkItemFn(_, _, _, ast::Constness::Const, _, _) => {
+ FnKind::ItemFn(_, _, _, ast::Constness::Const, _, _) => {
Mode::ConstFn
}
- visit::FkMethod(_, m, _) => {
+ FnKind::Method(_, m, _) => {
if m.constness == ast::Constness::Const {
Mode::ConstFn
} else {
}
fn visit_fn(&mut self,
- fk: visit::FnKind<'v>,
+ fk: FnKind<'v>,
fd: &'v ast::FnDecl,
b: &'v ast::Block,
s: Span,
sp: Span,
fn_id: NodeId) {
match kind {
- visit::FkClosure => {}
+ FnKind::Closure => {}
_ => cx.param_env = ParameterEnvironment::for_item(cx.tcx, fn_id),
}
// option. This file may not be copied, modified, or distributed
// except according to those terms.
-#![allow(non_camel_case_types)]
+//#![allow(non_camel_case_types)]
use self::ConstVal::*;
use self::ErrKind::*;
use util::num::ToPrimitive;
use syntax::ast::{self, Expr};
-use syntax::codemap::Span;
+use syntax::codemap::{self, Span};
use syntax::parse::token::InternedString;
use syntax::ptr::P;
-use syntax::{codemap, visit};
+use syntax::visit::FnKind;
use std::borrow::{Cow, IntoCow};
use std::num::wrapping::OverflowingOps;
};
match fn_like.kind() {
- visit::FkItemFn(_, _, _, ast::Constness::Const, _, _) => {
+ FnKind::ItemFn(_, _, _, ast::Constness::Const, _, _) => {
Some(fn_like)
}
- visit::FkMethod(_, m, _) => {
+ FnKind::Method(_, m, _) => {
if m.constness == ast::Constness::Const {
Some(fn_like)
} else {
use syntax::ast;
use syntax::codemap::Span;
use syntax::visit;
-use syntax::visit::Visitor;
+use syntax::visit::{FnKind, Visitor};
#[derive(Copy, Clone)]
struct UnsafeContext {
}
impl<'a, 'tcx, 'v> Visitor<'v> for EffectCheckVisitor<'a, 'tcx> {
- fn visit_fn(&mut self, fn_kind: visit::FnKind<'v>, fn_decl: &'v ast::FnDecl,
+ fn visit_fn(&mut self, fn_kind: FnKind<'v>, fn_decl: &'v ast::FnDecl,
block: &'v ast::Block, span: Span, _: ast::NodeId) {
let (is_item_fn, is_unsafe_fn) = match fn_kind {
- visit::FkItemFn(_, _, unsafety, _, _, _) =>
+ FnKind::ItemFn(_, _, unsafety, _, _, _) =>
(true, unsafety == ast::Unsafety::Unsafe),
- visit::FkMethod(_, sig, _) =>
+ FnKind::Method(_, sig, _) =>
(true, sig.unsafety == ast::Unsafety::Unsafe),
_ => (false, false),
};
use syntax::abi::RustIntrinsic;
use syntax::ast;
use syntax::codemap::Span;
-use syntax::visit::Visitor;
+use syntax::visit::{FnKind, Visitor};
use syntax::visit;
pub fn check_crate(tcx: &ctxt) {
}
impl<'a, 'tcx, 'v> Visitor<'v> for IntrinsicCheckingVisitor<'a, 'tcx> {
- fn visit_fn(&mut self, fk: visit::FnKind<'v>, fd: &'v ast::FnDecl,
+ fn visit_fn(&mut self, fk: FnKind<'v>, fd: &'v ast::FnDecl,
b: &'v ast::Block, s: Span, id: ast::NodeId) {
match fk {
- visit::FkItemFn(..) | visit::FkMethod(..) => {
+ FnKind::ItemFn(..) | FnKind::Method(..) => {
let param_env = ty::ParameterEnvironment::for_item(self.tcx, id);
self.param_envs.push(param_env);
visit::walk_fn(self, fk, fd, b, s);
self.param_envs.pop();
}
- visit::FkClosure(..) => {
+ FnKind::Closure(..) => {
visit::walk_fn(self, fk, fd, b, s);
}
}
use syntax::parse::token::special_idents;
use syntax::print::pprust::lifetime_to_string;
use syntax::visit;
-use syntax::visit::Visitor;
+use syntax::visit::{FnKind, Visitor};
use util::nodemap::NodeMap;
#[derive(Clone, Copy, PartialEq, Eq, Hash, RustcEncodable, RustcDecodable, Debug)]
replace(&mut self.labels_in_fn, saved);
}
- fn visit_fn(&mut self, fk: visit::FnKind<'v>, fd: &'v ast::FnDecl,
+ fn visit_fn(&mut self, fk: FnKind<'v>, fd: &'v ast::FnDecl,
b: &'v ast::Block, s: Span, _: ast::NodeId) {
match fk {
- visit::FkItemFn(_, generics, _, _, _, _) => {
+ FnKind::ItemFn(_, generics, _, _, _, _) => {
self.visit_early_late(subst::FnSpace, generics, |this| {
this.walk_fn(fk, fd, b, s)
})
}
- visit::FkMethod(_, sig, _) => {
+ FnKind::Method(_, sig, _) => {
self.visit_early_late(subst::FnSpace, &sig.generics, |this| {
this.walk_fn(fk, fd, b, s)
})
}
- visit::FkClosure(..) => {
+ FnKind::Closure(..) => {
self.walk_fn(fk, fd, b, s)
}
}
// labels of the function body and swaps them in before visiting
// the function body itself.
fn walk_fn<'b>(&mut self,
- fk: visit::FnKind,
+ fk: FnKind,
fd: &ast::FnDecl,
fb: &'b ast::Block,
_span: Span) {
match fk {
- visit::FkItemFn(_, generics, _, _, _, _) => {
+ FnKind::ItemFn(_, generics, _, _, _, _) => {
visit::walk_fn_decl(self, fd);
self.visit_generics(generics);
}
- visit::FkMethod(_, sig, _) => {
+ FnKind::Method(_, sig, _) => {
visit::walk_fn_decl(self, fd);
self.visit_generics(&sig.generics);
self.visit_explicit_self(&sig.explicit_self);
}
- visit::FkClosure(..) => {
+ FnKind::Closure(..) => {
visit::walk_fn_decl(self, fd);
}
}
fn visit_fn(&mut self, fk: FnKind<'v>, fd: &'v FnDecl,
b: &'v Block, s: Span, id: ast::NodeId) {
match fk {
- visit::FkItemFn(..) |
- visit::FkMethod(..) => {
+ FnKind::ItemFn(..) |
+ FnKind::Method(..) => {
let new_free_region_map = self.tcx.free_region_map(id);
let old_free_region_map =
mem::replace(&mut self.free_region_map, new_free_region_map);
self.free_region_map = old_free_region_map;
}
- visit::FkClosure => {
+ FnKind::Closure => {
borrowck_fn(self, fk, fd, b, s, id);
}
}
use syntax::feature_gate::{KNOWN_ATTRIBUTES, AttributeType};
use syntax::ast::{TyIs, TyUs, TyI8, TyU8, TyI16, TyU16, TyI32, TyU32, TyI64, TyU64};
use syntax::ptr::P;
-use syntax::visit::{self, Visitor};
+use syntax::visit::{self, FnKind, Visitor};
// hardwired lints from librustc
pub use lint::builtin::*;
}
fn check_fn(&mut self, cx: &Context,
- fk: visit::FnKind, _: &ast::FnDecl,
+ fk: FnKind, _: &ast::FnDecl,
_: &ast::Block, span: Span, id: ast::NodeId) {
match fk {
- visit::FkMethod(ident, _, _) => match method_context(cx, id, span) {
+ FnKind::Method(ident, _, _) => match method_context(cx, id, span) {
MethodContext::PlainImpl => {
self.check_snake_case(cx, "method", &ident.name.as_str(), Some(span))
},
},
_ => (),
},
- visit::FkItemFn(ident, _, _, _, _, _) => {
+ FnKind::ItemFn(ident, _, _, _, _, _) => {
self.check_snake_case(cx, "function", &ident.name.as_str(), Some(span))
},
_ => (),
}
}
- fn check_fn(&mut self, cx: &Context, fk: visit::FnKind, _: &ast::FnDecl,
+ fn check_fn(&mut self, cx: &Context, fk: FnKind, _: &ast::FnDecl,
_: &ast::Block, span: Span, _: ast::NodeId) {
match fk {
- visit::FkItemFn(_, _, ast::Unsafety::Unsafe, _, _, _) =>
+ FnKind::ItemFn(_, _, ast::Unsafety::Unsafe, _, _, _) =>
cx.span_lint(UNSAFE_CODE, span, "declaration of an `unsafe` function"),
- visit::FkMethod(_, sig, _) => {
+ FnKind::Method(_, sig, _) => {
if sig.unsafety == ast::Unsafety::Unsafe {
cx.span_lint(UNSAFE_CODE, span, "implementation of an `unsafe` method")
}
}
fn check_fn(&mut self, cx: &Context,
- _: visit::FnKind, decl: &ast::FnDecl,
+ _: FnKind, decl: &ast::FnDecl,
_: &ast::Block, _: Span, _: ast::NodeId) {
for a in &decl.inputs {
self.check_unused_mut_pat(cx, slice::ref_slice(&a.pat));
lint_array![UNCONDITIONAL_RECURSION]
}
- fn check_fn(&mut self, cx: &Context, fn_kind: visit::FnKind, _: &ast::FnDecl,
+ fn check_fn(&mut self, cx: &Context, fn_kind: FnKind, _: &ast::FnDecl,
blk: &ast::Block, sp: Span, id: ast::NodeId) {
type F = for<'tcx> fn(&ty::ctxt<'tcx>,
ast::NodeId, ast::NodeId, ast::Ident, ast::NodeId) -> bool;
let method = match fn_kind {
- visit::FkItemFn(..) => None,
- visit::FkMethod(..) => {
+ FnKind::ItemFn(..) => None,
+ FnKind::Method(..) => {
cx.tcx.impl_or_trait_item(DefId::local(id)).as_opt_method()
}
// closures can't recur, so they don't matter.
- visit::FkClosure => return
+ FnKind::Closure => return
};
// Walk through this function (say `f`) looking to see if
use syntax::parse::token::{self, special_names, special_idents};
use syntax::ptr::P;
use syntax::codemap::{self, Span, Pos};
-use syntax::visit::{self, Visitor};
+use syntax::visit::{self, FnKind, Visitor};
use std::collections::{HashMap, HashSet};
use std::collections::hash_map::Entry::{Occupied, Vacant};
});
}
fn visit_fn(&mut self,
- function_kind: visit::FnKind<'v>,
+ function_kind: FnKind<'v>,
declaration: &'v FnDecl,
block: &'v Block,
_: Span,
node_id: NodeId) {
let rib_kind = match function_kind {
- visit::FkItemFn(_, generics, _, _, _, _) => {
+ FnKind::ItemFn(_, generics, _, _, _, _) => {
self.visit_generics(generics);
ItemRibKind
}
- visit::FkMethod(_, sig, _) => {
+ FnKind::Method(_, sig, _) => {
self.visit_generics(&sig.generics);
self.visit_explicit_self(&sig.explicit_self);
MethodRibKind
}
- visit::FkClosure(..) => ClosureRibKind(node_id)
+ FnKind::Closure(..) => ClosureRibKind(node_id)
};
self.resolve_function(rib_kind, declaration, block);
}
use syntax::codemap::{DUMMY_SP, Span};
use syntax::parse::token::{special_idents};
use syntax::visit;
-use syntax::visit::Visitor;
+use syntax::visit::{FnKind, Visitor};
pub struct CheckTypeWellFormedVisitor<'ccx, 'tcx:'ccx> {
ccx: &'ccx CrateCtxt<'ccx, 'tcx>,
}
fn visit_fn(&mut self,
- fk: visit::FnKind<'v>, fd: &'v ast::FnDecl,
+ fk: FnKind<'v>, fd: &'v ast::FnDecl,
b: &'v ast::Block, span: Span, id: ast::NodeId) {
match fk {
- visit::FkClosure | visit::FkItemFn(..) => {}
- visit::FkMethod(..) => {
+ FnKind::Closure | FnKind::ItemFn(..) => {}
+ FnKind::Method(..) => {
match self.tcx().impl_or_trait_item(DefId::local(id)) {
ty::ImplOrTraitItem::MethodTraitItem(ty_method) => {
reject_shadowing_type_parameters(self.tcx(), span, &ty_method.generics)
use parse::token;
use print::pprust;
use ptr::P;
-use visit::Visitor;
+use visit::{FnKind, Visitor};
use visit;
use std::cmp;
node_id: NodeId) {
if !self.pass_through_items {
match function_kind {
- visit::FkMethod(..) if self.visited_outermost => return,
- visit::FkMethod(..) => self.visited_outermost = true,
+ FnKind::Method(..) if self.visited_outermost => return,
+ FnKind::Method(..) => self.visited_outermost = true,
_ => {}
}
}
self.operation.visit_id(node_id);
match function_kind {
- visit::FkItemFn(_, generics, _, _, _, _) => {
+ FnKind::ItemFn(_, generics, _, _, _, _) => {
self.visit_generics_helper(generics)
}
- visit::FkMethod(_, sig, _) => {
+ FnKind::Method(_, sig, _) => {
self.visit_generics_helper(&sig.generics)
}
- visit::FkClosure => {}
+ FnKind::Closure => {}
}
for argument in &function_declaration.inputs {
span);
if !self.pass_through_items {
- if let visit::FkMethod(..) = function_kind {
+ if let FnKind::Method(..) = function_kind {
self.visited_outermost = false;
}
}
}
/// Computes the id range for a single fn body, ignoring nested items.
-pub fn compute_id_range_for_fn_body(fk: visit::FnKind,
+pub fn compute_id_range_for_fn_body(fk: FnKind,
decl: &FnDecl,
body: &Block,
sp: Span,
use codemap::{CodeMap, Span};
use diagnostic::SpanHandler;
use visit;
-use visit::Visitor;
+use visit::{FnKind, Visitor};
use parse::token::{self, InternedString};
use std::ascii::AsciiExt;
}
fn visit_fn(&mut self,
- fn_kind: visit::FnKind<'v>,
+ fn_kind: FnKind<'v>,
fn_decl: &'v ast::FnDecl,
block: &'v ast::Block,
span: Span,
_node_id: NodeId) {
// check for const fn declarations
match fn_kind {
- visit::FkItemFn(_, _, _, ast::Constness::Const, _, _) => {
+ FnKind::ItemFn(_, _, _, ast::Constness::Const, _, _) => {
self.gate_feature("const_fn", span, "const fn is unstable");
}
_ => {
}
match fn_kind {
- visit::FkItemFn(_, _, _, _, abi, _) if abi == Abi::RustIntrinsic => {
+ FnKind::ItemFn(_, _, _, _, abi, _) if abi == Abi::RustIntrinsic => {
self.gate_feature("intrinsics",
span,
"intrinsics are subject to change")
}
- visit::FkItemFn(_, _, _, _, abi, _) |
- visit::FkMethod(_, &ast::MethodSig { abi, .. }, _) if abi == Abi::RustCall => {
+ FnKind::ItemFn(_, _, _, _, abi, _) |
+ FnKind::Method(_, &ast::MethodSig { abi, .. }, _) if abi == Abi::RustCall => {
self.gate_feature("unboxed_closures",
span,
"rust-call ABI is subject to change")
//! instance, a walker looking for item names in a module will miss all of
//! those that are created by the expansion of a macro.
-pub use self::FnKind::*;
-
use abi::Abi;
use ast::*;
use ast;
#[derive(Copy, Clone, PartialEq, Eq)]
pub enum FnKind<'a> {
/// fn foo() or extern "Abi" fn foo()
- FkItemFn(Ident, &'a Generics, Unsafety, Constness, Abi, Visibility),
+ ItemFn(Ident, &'a Generics, Unsafety, Constness, Abi, Visibility),
/// fn foo(&self)
- FkMethod(Ident, &'a MethodSig, Option<Visibility>),
+ Method(Ident, &'a MethodSig, Option<Visibility>),
/// |x, y| {}
- FkClosure,
+ Closure,
}
/// Each method of the Visitor trait is a hook to be potentially
visitor.visit_expr(&**expr);
}
ItemFn(ref declaration, unsafety, constness, abi, ref generics, ref body) => {
- visitor.visit_fn(FkItemFn(item.ident, generics, unsafety,
- constness, abi, item.vis),
+ visitor.visit_fn(FnKind::ItemFn(item.ident, generics, unsafety,
+ constness, abi, item.vis),
&**declaration,
&**body,
item.span,
walk_fn_decl(visitor, function_declaration);
match function_kind {
- FkItemFn(_, generics, _, _, _, _) => {
+ FnKind::ItemFn(_, generics, _, _, _, _) => {
visitor.visit_generics(generics);
}
- FkMethod(_, sig, _) => {
+ FnKind::Method(_, sig, _) => {
visitor.visit_generics(&sig.generics);
visitor.visit_explicit_self(&sig.explicit_self);
}
- FkClosure(..) => {}
+ FnKind::Closure(..) => {}
}
visitor.visit_block(function_body)
walk_fn_decl(visitor, &sig.decl);
}
MethodTraitItem(ref sig, Some(ref body)) => {
- visitor.visit_fn(FkMethod(trait_item.ident, sig, None), &sig.decl,
+ visitor.visit_fn(FnKind::Method(trait_item.ident, sig, None), &sig.decl,
body, trait_item.span, trait_item.id);
}
TypeTraitItem(ref bounds, ref default) => {
visitor.visit_expr(expr);
}
MethodImplItem(ref sig, ref body) => {
- visitor.visit_fn(FkMethod(impl_item.ident, sig, Some(impl_item.vis)), &sig.decl,
+ visitor.visit_fn(FnKind::Method(impl_item.ident, sig, Some(impl_item.vis)), &sig.decl,
body, impl_item.span, impl_item.id);
}
TypeImplItem(ref ty) => {
}
}
ExprClosure(_, ref function_declaration, ref body) => {
- visitor.visit_fn(FkClosure,
+ visitor.visit_fn(FnKind::Closure,
&**function_declaration,
&**body,
expression.span,