]> git.lizzy.rs Git - rust.git/commitdiff
Add an i128_lowering flag in TargetOptions
authorScott McMurray <scottmcm@users.noreply.github.com>
Mon, 4 Dec 2017 05:53:48 +0000 (21:53 -0800)
committerScott McMurray <scottmcm@users.noreply.github.com>
Mon, 4 Dec 2017 05:53:48 +0000 (21:53 -0800)
Not actually enabled by default anywhere yet.

src/librustc/session/config.rs
src/librustc_back/target/mod.rs
src/librustc_mir/transform/lower_128bit.rs
src/test/mir-opt/lower_128bit_debug_test.rs
src/test/mir-opt/lower_128bit_test.rs

index 70b63886084f5ae206435585104dff4bda5d7e4d..81e18fe536d6e31903c7b2822e65131a87a15bfa 100644 (file)
@@ -1176,9 +1176,10 @@ fn parse_optimization_fuel(slot: &mut Option<(String, u64)>, v: Option<&str>) ->
     saturating_float_casts: bool = (false, parse_bool, [TRACKED],
         "make float->int casts UB-free: numbers outside the integer type's range are clipped to \
          the max/min integer respectively, and NaN is mapped to 0"),
-    lower_128bit_ops: bool = (false, parse_bool, [TRACKED],
+    lower_128bit_ops: Option<bool> = (None, parse_opt_bool, [TRACKED],
         "rewrite operators on i128 and u128 into lang item calls (typically provided \
-         by compiler-builtins) so translation doesn't need to support them"),
+         by compiler-builtins) so translation doesn't need to support them,
+         overriding the default for the current target"),
 }
 
 pub fn default_lib_output() -> CrateType {
index 7599a60ba5ada27f5d527e0449ed28b7251d31da..6f9ba5dada2d8877cc1636d41b1bb75005f366f5 100644 (file)
@@ -453,6 +453,10 @@ pub struct TargetOptions {
     /// Whether library functions call lowering/optimization is disabled in LLVM
     /// for this target unconditionally.
     pub no_builtins: bool,
+
+    /// Whether to lower 128-bit operations to compiler_builtins calls.  Use if
+    /// your backend only supports 64-bit and smaller math.
+    pub i128_lowering: bool,
 }
 
 impl Default for TargetOptions {
@@ -521,6 +525,7 @@ fn default() -> TargetOptions {
             requires_lto: false,
             singlethread: false,
             no_builtins: false,
+            i128_lowering: false,
         }
     }
 }
index 7027d827c84f5caf1404c53a3b620dc098f0ffb4..80456efff830a53080dfec4d8bceffa2e9aaa5d6 100644 (file)
@@ -25,7 +25,9 @@ fn run_pass<'a, 'tcx>(&self,
                           tcx: TyCtxt<'a, 'tcx, 'tcx>,
                           _src: MirSource,
                           mir: &mut Mir<'tcx>) {
-        if !tcx.sess.opts.debugging_opts.lower_128bit_ops {
+        let debugging_override = tcx.sess.opts.debugging_opts.lower_128bit_ops;
+        let target_default = tcx.sess.host.options.i128_lowering;
+        if !debugging_override.unwrap_or(target_default) {
             return
         }
 
index 4f9bb809e99283fc7291a8b8ddb05a9ee3753f13..82d081555479994d4a24bc15ec565d38d40c168d 100644 (file)
@@ -13,7 +13,7 @@
 // ignore-asmjs
 // ignore-emscripten
 
-// compile-flags: -Z lower_128bit_ops -C debug_assertions=yes
+// compile-flags: -Z lower_128bit_ops=yes -C debug_assertions=yes
 
 #![feature(i128_type)]
 
index e8c8412db80efdae0d258ea93fc5c3ae728b7260..4b54f9a6d44f4c6b88959d90cd5adacd2243a16c 100644 (file)
@@ -13,7 +13,7 @@
 // ignore-asmjs
 // ignore-emscripten
 
-// compile-flags: -Z lower_128bit_ops -C debug_assertions=no
+// compile-flags: -Z lower_128bit_ops=yes -C debug_assertions=no
 
 #![feature(i128_type)]