]> git.lizzy.rs Git - BoundingBoxOutlineReloaded.git/commitdiff
Tidy up
authorIrtimaled <irtimaled@gmail.com>
Mon, 4 May 2020 00:07:43 +0000 (17:07 -0700)
committerIrtimaled <irtimaled@gmail.com>
Mon, 18 May 2020 00:28:00 +0000 (17:28 -0700)
38 files changed:
src/main/java/com/irtimaled/bbor/client/ClientProxy.java
src/main/java/com/irtimaled/bbor/client/ClientRenderer.java
src/main/java/com/irtimaled/bbor/client/commands/SeedCommand.java
src/main/java/com/irtimaled/bbor/client/gui/IntSettingSlider.java
src/main/java/com/irtimaled/bbor/client/keyboard/CustomKeyBinding.java
src/main/java/com/irtimaled/bbor/client/keyboard/Key.java
src/main/java/com/irtimaled/bbor/client/keyboard/KeyListener.java
src/main/java/com/irtimaled/bbor/client/providers/BeaconProvider.java
src/main/java/com/irtimaled/bbor/client/providers/CustomBoxProvider.java
src/main/java/com/irtimaled/bbor/client/providers/Iterators.java
src/main/java/com/irtimaled/bbor/client/providers/SpawningSphereProvider.java
src/main/java/com/irtimaled/bbor/client/providers/WorldSpawnProvider.java
src/main/java/com/irtimaled/bbor/client/renderers/AbstractRenderer.java
src/main/java/com/irtimaled/bbor/client/renderers/OffsetBox.java
src/main/java/com/irtimaled/bbor/client/renderers/Renderer.java
src/main/java/com/irtimaled/bbor/client/renderers/SpawningSphereRenderer.java
src/main/java/com/irtimaled/bbor/common/BoundingBoxCache.java
src/main/java/com/irtimaled/bbor/common/BoundingBoxType.java
src/main/java/com/irtimaled/bbor/common/CommonProxy.java
src/main/java/com/irtimaled/bbor/common/EventBus.java
src/main/java/com/irtimaled/bbor/common/TypeHelper.java
src/main/java/com/irtimaled/bbor/common/VillageColorCache.java
src/main/java/com/irtimaled/bbor/common/VillageProcessor.java
src/main/java/com/irtimaled/bbor/common/events/PlayerLoggedOut.java
src/main/java/com/irtimaled/bbor/common/events/ServerWorldTick.java
src/main/java/com/irtimaled/bbor/common/messages/PayloadBuilder.java
src/main/java/com/irtimaled/bbor/common/messages/PayloadReader.java
src/main/java/com/irtimaled/bbor/common/models/BoundingBoxBeacon.java
src/main/java/com/irtimaled/bbor/common/models/BoundingBoxCuboid.java
src/main/java/com/irtimaled/bbor/common/models/BoundingBoxMobSpawner.java
src/main/java/com/irtimaled/bbor/common/models/BoundingBoxSpawningSphere.java
src/main/java/com/irtimaled/bbor/common/models/BoundingBoxSphere.java
src/main/java/com/irtimaled/bbor/common/models/BoundingBoxVillage.java
src/main/java/com/irtimaled/bbor/common/models/Colors.java
src/main/java/com/irtimaled/bbor/common/models/Coords.java
src/main/java/com/irtimaled/bbor/config/ConfigManager.java
src/main/java/com/irtimaled/bbor/config/Configuration.java
src/main/java/com/irtimaled/bbor/mixin/network/play/server/MixinSPacketCommandList.java

index ae8fee1ebc2c9163fce95cf545212e4a1be63438..503e64ee1ef2880266a337aa6fb2aaf283486fa0 100644 (file)
@@ -69,7 +69,7 @@ public class ClientProxy extends CommonProxy {
     }
 
     @Override
-    public void setSeed(long seed) {
+    protected void setSeed(long seed) {
         super.setSeed(seed);
         SlimeChunkProvider.setSeed(seed);
     }
@@ -77,6 +77,6 @@ public class ClientProxy extends CommonProxy {
     @Override
     protected void setWorldSpawn(int spawnX, int spawnZ) {
         super.setWorldSpawn(spawnX, spawnZ);
-        WorldSpawnProvider.setWorldSpan(spawnX, spawnZ);
+        WorldSpawnProvider.setWorldSpawn(spawnX, spawnZ);
     }
 }
index 62ea07c8650fbcae85306b78e7c56886f5d5b56e..769dbcd5e679dd595307475089f1509017b87d44 100644 (file)
@@ -18,7 +18,7 @@ public class ClientRenderer {
     private static final Map<Class<? extends AbstractBoundingBox>, AbstractRenderer> boundingBoxRendererMap = new HashMap<>();
 
     private static boolean active;
-    private static Set<IBoundingBoxProvider> providers = new HashSet<>();
+    private static final Set<IBoundingBoxProvider> providers = new HashSet<>();
 
     public static boolean getActive() {
         return active;
index e15177a7705322d6be03859baa8e9202d77d0eb8..a25e04c340beb1276e2f445c6832947880f3d8a1 100644 (file)
@@ -11,11 +11,14 @@ import net.minecraft.command.ISuggestionProvider;
 import net.minecraft.util.text.TextComponentString;
 
 public class SeedCommand {
+    private static final String COMMAND = "bbor:seed";
+    private static final String SEED = "seed";
+
     public static void register(CommandDispatcher<ISuggestionProvider> commandDispatcher) {
-        LiteralArgumentBuilder command = Commands.literal("bbor:seed")
-                .then(Commands.argument("seed", StringArgumentType.string())
+        LiteralArgumentBuilder command = Commands.literal(COMMAND)
+                .then(Commands.argument(SEED, StringArgumentType.string())
                         .executes(context -> {
-                            String argument = StringArgumentType.getString(context, "seed");
+                            String argument = StringArgumentType.getString(context, SEED);
                             handleSeedCommand(argument);
                             return 0;
                         }))
index edc724f49a40627e5975fc7d9b03677f4184e4d0..777572964edbea0eac0af9c7b3d4b47874f68f1a 100644 (file)
@@ -7,7 +7,7 @@ import java.util.Map;
 
 class IntSettingSlider extends AbstractSlider implements IRenderableControl {
     private final String prefix;
-    private Map<Integer, String> displayValues = new HashMap<>();
+    private final Map<Integer, String> displayValues = new HashMap<>();
 
     final Setting<Integer> setting;
     final int minValue;
index 1bf7c7ee132eaf920066dfd39a9d7ec4f6c784cf..49008072ccce3272c1e4652d4f538048552d5e0f 100644 (file)
@@ -21,4 +21,4 @@ class CustomKeyBinding extends KeyBinding {
     public Key getKey() {
         return key;
     }
-}
\ No newline at end of file
+}
index 4192d6bb3ed5c6e3287974f000912e0081f12e0e..cdcec3dbc426e81146cbd36cf6cee7804610579f 100644 (file)
@@ -8,7 +8,7 @@ import java.util.Set;
 public class Key {
     private int keyCode;
     private KeyHandler onKeyPress;
-    private Set<Key> subKeys = new HashSet<>();
+    private final Set<Key> subKeys = new HashSet<>();
     private boolean triggeredSincePress;
 
     Key(int keyCode) {
index e758719f90b4a17ef2d7317031668b62be6e5742..a43bd50e530926728f6aa3018736fb320ad948d7 100644 (file)
@@ -11,8 +11,8 @@ import java.util.Set;
 public class KeyListener {
     private static final Minecraft minecraft = Minecraft.getInstance();
     private static long mainWindowHandle;
-    private static Set<Key> keys = new HashSet<>();
-    private static Set<CustomKeyBinding> keyBindings = new HashSet<>();
+    private static final Set<Key> keys = new HashSet<>();
+    private static final Set<CustomKeyBinding> keyBindings = new HashSet<>();
     public static final String Category = "Bounding Box Outline Reloaded";
 
     public static void init() {
index c9f7cff5d93a54cf0001a8331c6c721da47f171b..bd49e50779fbe13b1cb2c6d26c6649d7813e3532 100644 (file)
@@ -10,7 +10,7 @@ import java.util.Map;
 import java.util.concurrent.ConcurrentHashMap;
 
 public class BeaconProvider implements IBoundingBoxProvider<BoundingBoxBeacon> {
-    private static Map<Integer, Map<Coords, BoundingBoxBeacon>> dimensionsCache = buildBeaconsCache();
+    private static final Map<Integer, Map<Coords, BoundingBoxBeacon>> dimensionsCache = buildBeaconsCache();
 
     private static Map<Integer, Map<Coords, BoundingBoxBeacon>> buildBeaconsCache() {
         Map<Integer, Map<Coords, BoundingBoxBeacon>> map = new HashMap<>();
index 51bb1f8f60554944389662a2170b741fb351cfa0..7ad259df145d5c66be499476ce01c8a5cca28eb0 100644 (file)
@@ -11,7 +11,7 @@ import java.util.Map;
 import java.util.concurrent.ConcurrentHashMap;
 
 public class CustomBoxProvider implements IBoundingBoxProvider<BoundingBoxCuboid> {
-    private static Map<Integer, Map<Integer, BoundingBoxCuboid>> dimensionCache = buildDimensionCache();
+    private static final Map<Integer, Map<Integer, BoundingBoxCuboid>> dimensionCache = buildDimensionCache();
 
     private static Map<Integer, Map<Integer, BoundingBoxCuboid>> buildDimensionCache() {
         Map<Integer, Map<Integer, BoundingBoxCuboid>> map = new HashMap<>();
index 8dac4e476b08d42cb43daf16b694774726997f9d..80bcc1bf731948eaee847238829ae5b28d1f1695 100644 (file)
@@ -21,7 +21,7 @@ class Iterators {
                 }
             };
         }
-    };
+    }
 
     static <T extends AbstractBoundingBox> Iterable<T> empty() {
         return new Empty<>();
index c54d9f35f5167cf0805ca21e293124588009701a..7b9460cbd559b56e0009ec7afbbdd6c3e080de36 100644 (file)
@@ -59,7 +59,7 @@ public class SpawningSphereProvider implements IBoundingBoxProvider<BoundingBoxS
         return SpawningSphereHelper.findSpawnableSpaces(center, center.getCoords(), size, size, (x, y, z) -> true);
     }
 
-    private static Iterable<BoundingBoxSpawningSphere> iterable = Iterators.singleton(() -> spawningSphere);
+    private static final Iterable<BoundingBoxSpawningSphere> iterable = Iterators.singleton(() -> spawningSphere);
 
     public Iterable<BoundingBoxSpawningSphere> get(int dimensionId) {
         if(spawningSphere == null || SpawningSphereProvider.dimensionId != dimensionId) {
@@ -67,4 +67,4 @@ public class SpawningSphereProvider implements IBoundingBoxProvider<BoundingBoxS
         }
         return iterable;
     }
-}
\ No newline at end of file
+}
index e074c9ec80da0c16577cfb6133a2eb843ba5848a..d6b69f7dac0184beb20ad8587f8cc46d7a7da95a 100644 (file)
@@ -12,7 +12,7 @@ public class WorldSpawnProvider implements IBoundingBoxProvider<BoundingBoxWorld
     private static final double CHUNK_SIZE = 16d;
     private static Set<BoundingBoxWorldSpawn> spawnChunks = new HashSet<>();
 
-    public static void setWorldSpan(int spawnX, int spawnZ) {
+    public static void setWorldSpawn(int spawnX, int spawnZ) {
         spawnChunks = getSpawnChunkBoundingBoxes(spawnX, spawnZ);
     }
 
index 349382b6cd12d81ab417eb84d66b48bd6db78df8..c40665e40bc37a47102f103ca7d552a1c9a23137 100644 (file)
@@ -12,8 +12,8 @@ import java.util.HashSet;
 import java.util.Set;
 
 public abstract class AbstractRenderer<T extends AbstractBoundingBox> {
-    private static double TAU = 6.283185307179586D;
-    private static double PI = TAU / 2D;
+    private static final double TAU = 6.283185307179586D;
+    private static final double PI = TAU / 2D;
 
     public abstract void render(T boundingBox);
 
index cd26510434f08bd2942a59049b683f6f3018dc97..b629532a04bd1656d5f2a473f7cd7ef785595558 100644 (file)
@@ -29,7 +29,6 @@ class OffsetBox {
         return new OffsetBox(min.offset(x, y, z), max.offset(x, y, z));
     }
 
-
     OffsetBox nudge() {
         double growXZ = 0.001F;
         if (min.getY() == max.getY()) {
index 7f46a538597468b81d0fd8b8cbb09b2ed6fdd33e..a8906a260889c005a1011c600107fc95768eeefc 100644 (file)
@@ -25,8 +25,8 @@ public class Renderer {
         return new Renderer(GL11.GL_QUADS, DefaultVertexFormats.POSITION_TEX_COLOR);
     }
 
-    private Tessellator tessellator;
-    private BufferBuilder bufferBuilder;
+    private final Tessellator tessellator;
+    private final BufferBuilder bufferBuilder;
 
     private int red;
     private int green;
index 772af51b2b3db49aa3fd02e253f7026b4e4e76ef..e3ff7a7bd1309a4e576a88de763f4053fc614d3d 100644 (file)
@@ -19,7 +19,7 @@ public class SpawningSphereRenderer extends AbstractRenderer<BoundingBoxSpawning
 
         Integer spawnableSpacesCount = boundingBox.getSpawnableSpacesCount();
         if (spawnableSpacesCount != null) {
-            renderText(sphereCenter, "Spawnable", spawnableSpacesCount == 0 ? "None" : String.format("%,d", (int) spawnableSpacesCount));
+            renderText(sphereCenter, "Spawnable", spawnableSpacesCount == 0 ? "None" : String.format("%,d", spawnableSpacesCount));
         }
 
         renderSphere(sphereCenter, BoundingBoxSpawningSphere.SAFE_RADIUS, Color.GREEN, 5, 5);
index 39ede83990d5a018aff719fb996bd743fbbf7eec..99e9e425821f5ec2592bf556c45c53f6a2380612 100644 (file)
@@ -8,7 +8,7 @@ import java.util.Set;
 import java.util.concurrent.ConcurrentHashMap;
 
 public class BoundingBoxCache {
-    private Map<AbstractBoundingBox, Set<AbstractBoundingBox>> cache = new ConcurrentHashMap<>();
+    private final Map<AbstractBoundingBox, Set<AbstractBoundingBox>> cache = new ConcurrentHashMap<>();
 
     public Map<AbstractBoundingBox, Set<AbstractBoundingBox>> getBoundingBoxes() {
         return cache;
index 5d7edc5b13530db33c485fbf5b158b1b848be9b7..25463ffcba9dcfad7ec702825203c60b841a49cc 100644 (file)
@@ -9,33 +9,33 @@ import java.util.HashMap;
 import java.util.Map;
 
 public class BoundingBoxType {
-    private final static Map<Integer, BoundingBoxType> structureTypeMap = new HashMap<>();
+    private static final Map<Integer, BoundingBoxType> structureTypeMap = new HashMap<>();
 
-    public final static BoundingBoxType JungleTemple = register(Colors.DARK_GREEN, "Jungle_Pyramid", ConfigManager.drawJungleTemples);
-    public final static BoundingBoxType DesertTemple = register(Color.ORANGE, "Desert_Pyramid", ConfigManager.drawDesertTemples);
-    public final static BoundingBoxType WitchHut = register(Color.BLUE, "Swamp_Hut", ConfigManager.drawWitchHuts);
-    public final static BoundingBoxType OceanMonument = register(Color.CYAN, "Monument", ConfigManager.drawOceanMonuments);
-    public final static BoundingBoxType Shipwreck = register(Color.CYAN, "Shipwreck", ConfigManager.drawShipwrecks);
-    public final static BoundingBoxType OceanRuin = register(Color.CYAN, "Ocean_Ruin", ConfigManager.drawOceanRuins);
-    public final static BoundingBoxType BuriedTreasure = register(Color.CYAN, "Buried_Treasure", ConfigManager.drawBuriedTreasure);
-    public final static BoundingBoxType Stronghold = register(Color.YELLOW, "Stronghold", ConfigManager.drawStrongholds);
-    public final static BoundingBoxType MineShaft = register(Color.LIGHT_GRAY, "Mineshaft", ConfigManager.drawMineShafts);
-    public final static BoundingBoxType NetherFortress = register(Color.RED, "Fortress", ConfigManager.drawNetherFortresses);
-    public final static BoundingBoxType EndCity = register(Color.MAGENTA, "EndCity", ConfigManager.drawEndCities);
-    public final static BoundingBoxType Mansion = register(Colors.BROWN, "Mansion", ConfigManager.drawMansions);
-    public final static BoundingBoxType Igloo = register(Color.WHITE, "Igloo", ConfigManager.drawIgloos);
-    public final static BoundingBoxType PillagerOutpost = register(Color.DARK_GRAY, "Pillager_Outpost", ConfigManager.drawPillagerOutposts);
-    public final static BoundingBoxType WorldSpawn = register(Color.RED, "World_Spawn", ConfigManager.drawWorldSpawn);
-    public final static BoundingBoxType SpawnChunks = register(Color.RED, "Spawn_Chunks", ConfigManager.drawWorldSpawn);
-    public final static BoundingBoxType LazySpawnChunks = register(Color.RED, "Lazy_Chunks", ConfigManager.drawLazySpawnChunks);
-    public final static BoundingBoxType MobSpawner = register(Color.GREEN, "Mob_Spawner", ConfigManager.drawMobSpawners);
-    public final static BoundingBoxType SlimeChunks = register(Colors.DARK_GREEN, "Slime_Chunks", ConfigManager.drawSlimeChunks);
-    public final static BoundingBoxType Village = register(Colors.PURPLE, "Village", ConfigManager.drawVillages);
-    public final static BoundingBoxType VillageSpheres = register(null, "Village Sphere", ConfigManager.drawVillageSpheres);
-    public final static BoundingBoxType AFKSphere = register(Color.RED, "AFK Sphere", ConfigManager.drawAFKSpheres);
-    public final static BoundingBoxType BiomeBorder = register(Color.GREEN, "Biome Border", ConfigManager.drawBiomeBorders);
-    public final static BoundingBoxType Beacon = register(Color.WHITE, "Beacon", ConfigManager.drawBeacons);
-    public final static BoundingBoxType Custom = register(Color.WHITE, "Custom", ConfigManager.drawCustomBoxes);
+    public static final BoundingBoxType JungleTemple = register(Colors.DARK_GREEN, "Jungle_Pyramid", ConfigManager.drawJungleTemples);
+    public static final BoundingBoxType DesertTemple = register(Color.ORANGE, "Desert_Pyramid", ConfigManager.drawDesertTemples);
+    public static final BoundingBoxType WitchHut = register(Color.BLUE, "Swamp_Hut", ConfigManager.drawWitchHuts);
+    public static final BoundingBoxType OceanMonument = register(Color.CYAN, "Monument", ConfigManager.drawOceanMonuments);
+    public static final BoundingBoxType Shipwreck = register(Color.CYAN, "Shipwreck", ConfigManager.drawShipwrecks);
+    public static final BoundingBoxType OceanRuin = register(Color.CYAN, "Ocean_Ruin", ConfigManager.drawOceanRuins);
+    public static final BoundingBoxType BuriedTreasure = register(Color.CYAN, "Buried_Treasure", ConfigManager.drawBuriedTreasure);
+    public static final BoundingBoxType Stronghold = register(Color.YELLOW, "Stronghold", ConfigManager.drawStrongholds);
+    public static final BoundingBoxType MineShaft = register(Color.LIGHT_GRAY, "Mineshaft", ConfigManager.drawMineShafts);
+    public static final BoundingBoxType NetherFortress = register(Color.RED, "Fortress", ConfigManager.drawNetherFortresses);
+    public static final BoundingBoxType EndCity = register(Color.MAGENTA, "EndCity", ConfigManager.drawEndCities);
+    public static final BoundingBoxType Mansion = register(Colors.BROWN, "Mansion", ConfigManager.drawMansions);
+    public static final BoundingBoxType Igloo = register(Color.WHITE, "Igloo", ConfigManager.drawIgloos);
+    public static final BoundingBoxType PillagerOutpost = register(Color.DARK_GRAY, "Pillager_Outpost", ConfigManager.drawPillagerOutposts);
+    public static final BoundingBoxType WorldSpawn = register(Color.RED, "World_Spawn", ConfigManager.drawWorldSpawn);
+    public static final BoundingBoxType SpawnChunks = register(Color.RED, "Spawn_Chunks", ConfigManager.drawWorldSpawn);
+    public static final BoundingBoxType LazySpawnChunks = register(Color.RED, "Lazy_Chunks", ConfigManager.drawLazySpawnChunks);
+    public static final BoundingBoxType MobSpawner = register(Color.GREEN, "Mob_Spawner", ConfigManager.drawMobSpawners);
+    public static final BoundingBoxType SlimeChunks = register(Colors.DARK_GREEN, "Slime_Chunks", ConfigManager.drawSlimeChunks);
+    public static final BoundingBoxType Village = register(Colors.PURPLE, "Village", ConfigManager.drawVillages);
+    public static final BoundingBoxType VillageSpheres = register(null, "Village Sphere", ConfigManager.drawVillageSpheres);
+    public static final BoundingBoxType AFKSphere = register(Color.RED, "AFK Sphere", ConfigManager.drawAFKSpheres);
+    public static final BoundingBoxType BiomeBorder = register(Color.GREEN, "Biome Border", ConfigManager.drawBiomeBorders);
+    public static final BoundingBoxType Beacon = register(Color.WHITE, "Beacon", ConfigManager.drawBeacons);
+    public static final BoundingBoxType Custom = register(Color.WHITE, "Custom", ConfigManager.drawCustomBoxes);
 
     private static BoundingBoxType register(Color color, String name, Setting<Boolean> shouldRenderSetting) {
         return structureTypeMap.computeIfAbsent(name.hashCode(), k -> new BoundingBoxType(color, name, shouldRenderSetting));
index c447f11b95fb10774d2ca6ce32faa5428d3b126f..e00afd4792fbfbf768a9ac288a189ccf86dcd8e9 100644 (file)
@@ -21,10 +21,10 @@ import java.util.Set;
 import java.util.concurrent.ConcurrentHashMap;
 
 public class CommonProxy {
-    private Map<Integer, ServerPlayer> players = new ConcurrentHashMap<>();
-    private Map<Integer, Set<AbstractBoundingBox>> playerBoundingBoxesCache = new HashMap<>();
-    private Map<Integer, VillageProcessor> villageProcessors = new HashMap<>();
-    private Map<Integer, AbstractChunkProcessor> chunkProcessors = new HashMap<>();
+    private final Map<Integer, ServerPlayer> players = new ConcurrentHashMap<>();
+    private final Map<Integer, Set<AbstractBoundingBox>> playerBoundingBoxesCache = new HashMap<>();
+    private final Map<Integer, VillageProcessor> villageProcessors = new HashMap<>();
+    private final Map<Integer, AbstractChunkProcessor> chunkProcessors = new HashMap<>();
     private final Map<Integer, BoundingBoxCache> dimensionCache = new ConcurrentHashMap<>();
     private Long seed = null;
     private Integer spawnX = null;
index bc41db1224289aa6b83113573d0d91bdd2060721..f24f37291c8804df3301e1a1af2e2c207878b08a 100644 (file)
@@ -5,7 +5,7 @@ import java.util.Map;
 import java.util.function.Consumer;
 
 public class EventBus {
-    private static Map<Class<?>, Consumer<?>> handlers = new HashMap<>();
+    private static final Map<Class<?>, Consumer<?>> handlers = new HashMap<>();
 
     public static <evt> void publish(evt event) {
         if (event == null) return;
index 9b8ddd55d9b94001ca914bc2e95524308d462da5..c2de5a72ce36c209eae98ec686fa013ab91f159b 100644 (file)
@@ -17,4 +17,13 @@ public class TypeHelper {
         if (typedValue == null) return;
         consumer.accept(typedValue);
     }
+
+    public static int combineHashCodes(int... hashCodes) {
+        final int prime = 31;
+        int result = 0;
+        for (int hashCode : hashCodes) {
+            result = prime * result + hashCode;
+        }
+        return result;
+    }
 }
index d5071a7322485b01b3455d3b357fc5b31c27165f..4448f5c5c9aaf4dfead1e1f347333aecd60adede 100644 (file)
@@ -30,7 +30,7 @@ public class VillageColorCache {
         return Color.WHITE;
     }
 
-    private static Map<Integer, Color> villageColorCache = new HashMap<>();
+    private static final Map<Integer, Color> villageColorCache = new HashMap<>();
 
     public static Color getColor(int villageId) {
         return villageColorCache.computeIfAbsent(villageId, k -> getNextColor());
index 2e954ca8ae9fb3ea5cb4a5a85bc8a53aff1b8698..ac6b019b9ba4acc5aaded7f76ee9396f62737af2 100644 (file)
@@ -14,7 +14,7 @@ class VillageProcessor {
     private final BoundingBoxCache boundingBoxCache;
 
     private Map<Integer, BoundingBoxVillage> villageCache = new HashMap<>();
-    private int dimensionId;
+    private final int dimensionId;
 
     VillageProcessor(int dimensionId, BoundingBoxCache boundingBoxCache) {
         this.dimensionId = dimensionId;
index e21caaa716df5d69bc9ac00b49d376cd8789279c..c7262d75c8babdeb79a6cfcc202752781d29d0e0 100644 (file)
@@ -1,7 +1,7 @@
 package com.irtimaled.bbor.common.events;
 
 public class PlayerLoggedOut {
-    private int playerId;
+    private final int playerId;
 
     public PlayerLoggedOut(int playerId) {
         this.playerId = playerId;
index 8b20b87e9d349ea4aefe7fe6fad69c0947eb3784..3116143f5c757723503645e887c30373313009e0 100644 (file)
@@ -4,7 +4,7 @@ import net.minecraft.world.WorldServer;
 
 public class ServerWorldTick {
     private final int dimensionId;
-    private WorldServer world;
+    private final WorldServer world;
 
     public ServerWorldTick(WorldServer world) {
         this.world = world;
index ec2579a3a576a4e1a48b2b80c3a06188111a5c2a..d40cc235d8ee2d7285b26e7d8e24556a2c3b9910 100644 (file)
@@ -13,7 +13,7 @@ import java.util.Map;
 import java.util.function.BiFunction;
 
 public class PayloadBuilder {
-    private static Map<String, ResourceLocation> packetNames = new HashMap<>();
+    private static final Map<String, ResourceLocation> packetNames = new HashMap<>();
 
     static PayloadBuilder clientBound(String name) {
         return new PayloadBuilder(packetNames.computeIfAbsent(name, ResourceLocation::new), SPacketCustomPayload::new);
index 8af867dc3dedf33b45b58d5173f540f09a7157b0..4db5bb46b7692933adda1f0042985950a62fe2b2 100644 (file)
@@ -4,7 +4,7 @@ import com.irtimaled.bbor.common.models.Coords;
 import net.minecraft.network.PacketBuffer;
 
 public class PayloadReader {
-    private PacketBuffer buffer;
+    private final PacketBuffer buffer;
 
     public PayloadReader(PacketBuffer buffer) {
         this.buffer = buffer;
index db3f8a1024458ec9e9c7dfd3bc5b14b0ff2415ab..09e848750591ee3a6984ade4dc7dff3ad2608873 100644 (file)
@@ -19,29 +19,17 @@ public class BoundingBoxBeacon extends BoundingBoxCuboid {
 
     @Override
     public int hashCode() {
-        final int prime = 31;
-        int result = 1;
-        result = prime * result + coords.hashCode();
-        return result;
+        return coords.hashCode();
     }
 
     @Override
     public boolean equals(Object obj) {
-        if (this == obj)
-            return true;
-        if (obj == null)
-            return false;
-        if (getClass() != obj.getClass())
-            return false;
+        if (this == obj) return true;
+        if (obj == null || getClass() != obj.getClass()) return false;
         BoundingBoxBeacon other = (BoundingBoxBeacon) obj;
         return coords.equals(other.coords);
     }
 
-    @Override
-    public String toString() {
-        return "(" + coords.toString() + ")";
-    }
-
     public Coords getCoords() {
         return coords;
     }
index 1b1663a63681adaf47faf8cd99e43b664503f95f..d5a15d4043dab77de99bc5735702ef4610e9e77c 100644 (file)
@@ -1,6 +1,7 @@
 package com.irtimaled.bbor.common.models;
 
 import com.irtimaled.bbor.common.BoundingBoxType;
+import com.irtimaled.bbor.common.TypeHelper;
 
 public class BoundingBoxCuboid extends AbstractBoundingBox {
     private final Coords minCoords;
@@ -18,30 +19,17 @@ public class BoundingBoxCuboid extends AbstractBoundingBox {
 
     @Override
     public int hashCode() {
-        final int prime = 31;
-        int result = 1;
-        result = prime * result + minCoords.hashCode();
-        result = prime * result + maxCoords.hashCode();
-        return result;
+        return TypeHelper.combineHashCodes(minCoords.hashCode(), maxCoords.hashCode());
     }
 
     @Override
     public boolean equals(Object obj) {
-        if (this == obj)
-            return true;
-        if (obj == null)
-            return false;
-        if (getClass() != obj.getClass())
-            return false;
+        if (this == obj) return true;
+        if (obj == null || getClass() != obj.getClass()) return false;
         BoundingBoxCuboid other = (BoundingBoxCuboid) obj;
         return minCoords.equals(other.minCoords) && maxCoords.equals(other.maxCoords);
     }
 
-    @Override
-    public String toString() {
-        return "(" + minCoords.toString() + "; " + maxCoords.toString() + ")";
-    }
-
     public Coords getMinCoords() {
         return minCoords;
     }
index 9d5d22968528ed5ceaabc10914021ed72c7aba40..7a6d4cae67342ce3d1b1cc53e61b2678df02f9c4 100644 (file)
@@ -20,11 +20,6 @@ public class BoundingBoxMobSpawner extends BoundingBoxCuboid {
         return new BoundingBoxMobSpawner(coords, minCoords, maxCoords);
     }
 
-    @Override
-    public String toString() {
-        return "(" + coords.toString() + ")";
-    }
-
     public Coords getCoords() {
         return coords;
     }
index 38fb4c0556d8d8a33019d39c6658765b11ac1e85..1f72a3e0ed12768899d6c5df9a12ef5f2c22dce8 100644 (file)
@@ -9,7 +9,7 @@ public class BoundingBoxSpawningSphere extends BoundingBoxSphere {
     private Integer spawnableCount;
 
     public BoundingBoxSpawningSphere(Coords coords, double xOffset, double yOffset, double zOffset) {
-        super(BoundingBoxType.AFKSphere, coords, 128);
+        super(coords, 128, BoundingBoxType.AFKSphere);
         setCenterOffsets(xOffset, yOffset, zOffset);
     }
 
index c7fffed49b290cac208cb8aaedd08bdb40e948b4..af8f7584f290ff00c383bd934ecb02bf40293386 100644 (file)
@@ -14,7 +14,7 @@ public class BoundingBoxSphere extends AbstractBoundingBox {
     private Double centerOffsetY = 0d;
     private Double centerOffsetZ = 0d;
 
-    protected BoundingBoxSphere(BoundingBoxType type, Coords center, Integer radius) {
+    protected BoundingBoxSphere(Coords center, Integer radius, BoundingBoxType type) {
         super(type);
         this.center = center;
         this.radius = radius;
@@ -33,11 +33,6 @@ public class BoundingBoxSphere extends AbstractBoundingBox {
                 this.minZ <= maxZ;
     }
 
-    @Override
-    public String toString() {
-        return "(" + center.toString() + "; " + radius.toString() + ")";
-    }
-
     public Integer getRadius() {
         return radius;
     }
index d7e3ce776f392acb291d9549711a8c3c8b415ca2..9b2496ba619953d54b6e8367a28a9efa42081139 100644 (file)
@@ -1,6 +1,7 @@
 package com.irtimaled.bbor.common.models;
 
 import com.irtimaled.bbor.common.BoundingBoxType;
+import com.irtimaled.bbor.common.TypeHelper;
 import com.irtimaled.bbor.common.VillageColorCache;
 import com.irtimaled.bbor.common.VillageHelper;
 
@@ -10,11 +11,11 @@ import java.util.Set;
 public class BoundingBoxVillage extends BoundingBoxSphere {
     private final boolean spawnsIronGolems;
     private final Color color;
-    private Set<Coords> doors;
-    private int villageHash;
+    private final Set<Coords> doors;
+    private final int villageHash;
 
     private BoundingBoxVillage(Coords center, Integer radius, Color color, boolean spawnsIronGolems, Set<Coords> doors) {
-        super(BoundingBoxType.VillageSpheres, center, radius);
+        super(center, radius, BoundingBoxType.VillageSpheres);
         this.color = color;
         this.spawnsIronGolems = spawnsIronGolems;
         this.doors = doors;
@@ -63,7 +64,7 @@ public class BoundingBoxVillage extends BoundingBoxSphere {
 
     @Override
     public int hashCode() {
-        return (super.hashCode() * 31) + villageHash;
+        return TypeHelper.combineHashCodes(super.hashCode(), villageHash);
     }
 
     public boolean getSpawnsIronGolems() {
index 89739df422f297101572fd9edf9b8d414d313e0b..06d896834619b5cd39d4d5e34e28e460b505ae77 100644 (file)
@@ -3,8 +3,8 @@ package com.irtimaled.bbor.common.models;
 import java.awt.*;
 
 public class Colors {
-    public final static Color DARK_ORANGE = new Color(255, 127, 0);
-    public final static Color DARK_GREEN = new Color(0, 96, 0);
-    public final static Color BROWN = new Color(139, 69, 19);
-    public final static Color PURPLE = new Color(128, 0, 128);
+    public static final Color DARK_ORANGE = new Color(255, 127, 0);
+    public static final Color DARK_GREEN = new Color(0, 96, 0);
+    public static final Color BROWN = new Color(139, 69, 19);
+    public static final Color PURPLE = new Color(128, 0, 128);
 }
index d4fddb9b94002f22c9b82b319e330af5c54ace89..0768652d4ab6842d257a32216a9a4fb22f20675e 100644 (file)
@@ -38,22 +38,19 @@ public class Coords {
     }
 
     @Override
-    public boolean equals(Object other) {
-        if (this == other) {
-            return true;
-        }
-
-        Coords coords = TypeHelper.as(other, Coords.class);
-        return coords != null &&
-                this.getX() == coords.getX() &&
-                this.getY() == coords.getY() &&
-                this.getZ() == coords.getZ();
-
+    public int hashCode() {
+        return TypeHelper.combineHashCodes(z, y, x);
     }
 
     @Override
-    public int hashCode() {
-        return (this.getY() + this.getZ() * 31) * 31 + this.getX();
+    public boolean equals(Object obj) {
+        if (this == obj) return true;
+        if (obj == null || getClass() != obj.getClass()) return false;
+        Coords other = (Coords) obj;
+        return getX() == other.getX() &&
+                getY() == other.getY() &&
+                getZ() == other.getZ();
+
     }
 }
 
index c79a126397bc5303703a37f16718bef1b8bd1eb7..832607dcaee957ec8e4b4f4bcceeaecc556f34b3 100644 (file)
@@ -5,7 +5,7 @@ import java.util.HashSet;
 import java.util.Set;
 
 public class ConfigManager {
-    private static Set<Setting<?>> settings = new HashSet<>();
+    private static final Set<Setting<?>> settings = new HashSet<>();
     public static File configDir;
 
     public static Setting<Boolean> fill;
index fd3d50ccf0cd5501cf7eb67dcd87c809c6371a0d..f061093ccbbdd3f1b8340289f1893534d1f9cb16 100644 (file)
@@ -3,7 +3,6 @@ package com.irtimaled.bbor.config;
 import com.google.common.io.Files;
 
 import java.io.*;
-import java.nio.charset.Charset;
 import java.nio.charset.StandardCharsets;
 import java.util.HashMap;
 import java.util.List;
@@ -39,11 +38,11 @@ public class Configuration {
         }
     }
 
-    private Map<String, Map<String, Setting<?>>> settingsGroup = new HashMap<>();
+    private final Map<String, Map<String, Setting<?>>> settingsGroup = new HashMap<>();
 
     void load() {
         try {
-            List<String> lines = Files.readLines(file, Charset.forName("utf-8"));
+            List<String> lines = Files.readLines(file, StandardCharsets.UTF_8);
             String category = null;
             String lastCommentLine = null;
             for (String line : lines) {
@@ -95,7 +94,7 @@ public class Configuration {
         }
         Map<String, Setting<?>> settings = settingsGroup.get(category);
         Setting<?> setting = settings.get(settingName);
-        if (setting == null && category != FALLBACK_CATEGORY)
+        if (setting == null && !category.equals(FALLBACK_CATEGORY))
             setting = getFallbackSetting(settingName, settings);
         if (setting != null && setting.getType() != type) {
             setting = null;
index f4a49f74b47242f092d53a15cac78051e49dff49..30647e2901d080861c793dd28639bd7330cd9c57 100644 (file)
@@ -14,8 +14,7 @@ import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;
 public class MixinSPacketCommandList {
     @Inject(method = "processPacket", at= @At("RETURN"))
     private void processPacket(INetHandlerPlayClient netHandlerPlayClient, CallbackInfo ci) {
-        TypeHelper.doIfType(netHandlerPlayClient, NetHandlerPlayClient.class, handler -> {
-            ClientInterop.registerClientCommands(handler.func_195515_i());
-        });
+        TypeHelper.doIfType(netHandlerPlayClient, NetHandlerPlayClient.class, handler ->
+                ClientInterop.registerClientCommands(handler.func_195515_i()));
     }
 }