Make sure color returns to normal after a damage flash (#7332)

diff --git a/src/content_cao.cpp b/src/content_cao.cpp
index 9344b3370669c69f5e6d2bd8a8e5960680a1f3e7..1955559b5f4061c91a585d0a533cdc8126636bf5 100644 (file)
--- a/src/content_cao.cpp
+++ b/src/content_cao.cpp
@@ -990,7 +990,7 @@ void GenericCAO::updateTexturePos()
        }
 }
 
-void GenericCAO::updateTextures(const std::string &mod)
+void GenericCAO::updateTextures(std::string mod)
 {
        ITextureSource *tsrc = m_client->tsrc();
 

diff --git a/src/content_cao.h b/src/content_cao.h
index a93df664a2a6f8415ae4d873c324a674b3004720..d2c8d772e35af57ae75e445b31581053bc06a787 100644 (file)
--- a/src/content_cao.h
+++ b/src/content_cao.h
@@ -198,8 +198,8 @@ class GenericCAO : public ClientActiveObject
        void updateTexturePos();
 
        // std::string copy is mandatory as mod can be a class member and there is a swap
-       // on those class members
-       void updateTextures(const std::string &mod);
+       // on those class members... do NOT pass by reference
+       void updateTextures(std::string mod);
 
        void updateAnimation();