// FIXME: #6220 Implement floating point formatting
-#![allow(unsigned_negation)]
-
use prelude::*;
use fmt;
macro_rules! neg_impl_core {
($id:ident => $body:expr, $($t:ty)*) => ($(
#[stable(feature = "rust1", since = "1.0.0")]
- #[allow(unsigned_negation)]
impl Neg for $t {
#[stable(feature = "rust1", since = "1.0.0")]
type Output = $t;
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.
-#![allow(unsigned_negation)]
-
use core::fmt::radix;
#[test]
/// Refills the output buffer (`self.rsl`)
#[inline]
- #[allow(unsigned_negation)]
fn isaac(&mut self) {
self.c = self.c + w(1);
// abbreviations
// except according to those terms.
#![allow(non_camel_case_types)]
-#![allow(unsigned_negation)]
use self::ConstVal::*;
use syntax::ast::{self, Expr};
use syntax::ast_util;
use syntax::codemap::Span;
-use syntax::feature_gate;
use syntax::parse::token::InternedString;
use syntax::ptr::P;
use syntax::{codemap, visit};
Float(f) => Float(-f),
Int(n) => try!(const_int_checked_neg(n, e, expr_int_type)),
Uint(i) => {
- if !tcx.sess.features.borrow().negate_unsigned {
- feature_gate::emit_feature_err(
- &tcx.sess.parse_sess.span_diagnostic,
- "negate_unsigned",
- e.span,
- "unary negation of unsigned integers may be removed in the future");
- }
try!(const_uint_checked_neg(i, e, expr_uint_type))
}
Str(_) => signal!(e, NegateOnString),
use syntax::ast_util::{self, is_shift_binop, local_def};
use syntax::attr::{self, AttrMetaMethods};
use syntax::codemap::{self, Span};
-use syntax::feature_gate::{KNOWN_ATTRIBUTES, AttributeType};
+use syntax::feature_gate::{KNOWN_ATTRIBUTES, AttributeType, emit_feature_err};
use syntax::parse::token;
use syntax::ast::{TyIs, TyUs, TyI8, TyU8, TyI16, TyU16, TyI32, TyU32, TyI64, TyU64};
use syntax::ptr::P;
}
}
-declare_lint! {
- UNSIGNED_NEGATION,
- Warn,
- "using an unary minus operator on unsigned type"
-}
-
declare_lint! {
UNUSED_COMPARISONS,
Warn,
impl LintPass for TypeLimits {
fn get_lints(&self) -> LintArray {
- lint_array!(UNSIGNED_NEGATION, UNUSED_COMPARISONS, OVERFLOWING_LITERALS,
- EXCEEDING_BITSHIFTS)
+ lint_array!(UNUSED_COMPARISONS, OVERFLOWING_LITERALS, EXCEEDING_BITSHIFTS)
}
fn check_expr(&mut self, cx: &Context, e: &ast::Expr) {
ast::ExprLit(ref lit) => {
match lit.node {
ast::LitInt(_, ast::UnsignedIntLit(_)) => {
- cx.span_lint(UNSIGNED_NEGATION, e.span,
- "negation of unsigned int literal may \
- be unintentional");
+ check_unsigned_negation_feature(cx, e.span);
+ },
+ ast::LitInt(_, ast::UnsuffixedIntLit(_)) => {
+ if let ty::TyUint(_) = cx.tcx.expr_ty(e).sty {
+ check_unsigned_negation_feature(cx, e.span);
+ }
},
_ => ()
}
let t = cx.tcx.expr_ty(&**expr);
match t.sty {
ty::TyUint(_) => {
- cx.span_lint(UNSIGNED_NEGATION, e.span,
- "negation of unsigned int variable may \
- be unintentional");
+ check_unsigned_negation_feature(cx, e.span);
},
_ => ()
}
_ => false
}
}
+
+ fn check_unsigned_negation_feature(cx: &Context, span: Span) {
+ if !cx.sess().features.borrow().negate_unsigned {
+ emit_feature_err(
+ &cx.sess().parse_sess.span_diagnostic,
+ "negate_unsigned",
+ span,
+ "unary negation of unsigned integers may be removed in the future");
+ }
+ }
}
}
//! used unboxed and any field can have pointers (including mutable)
//! taken to it, implementing them for Rust seems difficult.
-#![allow(unsigned_negation)]
-
pub use self::Repr::*;
use std::rc::Rc;
use syntax::ast::{self, DefId, Visibility};
use syntax::ast_util::{self, local_def};
use syntax::codemap::{self, Span};
-use syntax::feature_gate;
use syntax::owned_slice::OwnedSlice;
use syntax::parse::token;
use syntax::print::pprust;
tcx.lang_items.neg_trait(),
expr, &**oprnd, oprnd_t, unop);
}
- if let ty::TyUint(_) = oprnd_t.sty {
- if !tcx.sess.features.borrow().negate_unsigned {
- feature_gate::emit_feature_err(
- &tcx.sess.parse_sess.span_diagnostic,
- "negate_unsigned",
- expr.span,
- "unary negation of unsigned integers may be removed in the future");
- }
- }
}
}
}
#![stable(feature = "rust1", since = "1.0.0")]
#![allow(missing_docs)]
-#![allow(unsigned_negation)]
#![doc(primitive = "f32")]
use prelude::v1::*;
// except according to those terms.
#![doc(hidden)]
-#![allow(unsigned_negation)]
macro_rules! uint_module { ($T:ident) => (
// evaluation below (e.g. that performed by trans and llvm), so if you
// change this warn to a deny, then the compiler will exit before
// those errors are detected.
-#![warn(unsigned_negation)]
use std::fmt;
use std::{i8, i16, i32, i64, isize};
const VALS_U8: (u8, u8, u8, u8) =
(-u8::MIN,
- //~^ WARNING negation of unsigned int variable may be unintentional
- // (The above is separately linted; unsigned negation is defined to be !x+1.)
u8::MIN - 1,
//~^ ERROR attempted to sub with overflow
u8::MAX + 1,
const VALS_U16: (u16, u16, u16, u16) =
(-u16::MIN,
- //~^ WARNING negation of unsigned int variable may be unintentional
- // (The above is separately linted; unsigned negation is defined to be !x+1.)
u16::MIN - 1,
//~^ ERROR attempted to sub with overflow
u16::MAX + 1,
const VALS_U32: (u32, u32, u32, u32) =
(-u32::MIN,
- //~^ WARNING negation of unsigned int variable may be unintentional
- // (The above is separately linted; unsigned negation is defined to be !x+1.)
u32::MIN - 1,
//~^ ERROR attempted to sub with overflow
u32::MAX + 1,
const VALS_U64: (u64, u64, u64, u64) =
(-u64::MIN,
- //~^ WARNING negation of unsigned int variable may be unintentional
- // (The above is separately linted; unsigned negation is defined to be !x+1.)
u64::MIN - 1,
//~^ ERROR attempted to sub with overflow
u64::MAX + 1,
// Test that negating unsigned integers is gated by `negate_unsigned` feature
// gate
-const MAX: usize = -1;
+struct S;
+impl std::ops::Neg for S {
+ type Output = u32;
+ fn neg(self) -> u32 { 0 }
+}
+
+const _MAX: usize = -1;
//~^ ERROR unary negation of unsigned integers may be removed in the future
-fn main() {}
+fn main() {
+ let a = -1;
+ //~^ ERROR unary negation of unsigned integers may be removed in the future
+ let _b : u8 = a; // for infering variable a to u8.
+
+ -a;
+ //~^ ERROR unary negation of unsigned integers may be removed in the future
+
+ let _d = -1u8;
+ //~^ ERROR unary negation of unsigned integers may be removed in the future
+
+ for _ in -10..10u8 {}
+ //~^ ERROR unary negation of unsigned integers may be removed in the future
+
+ -S; // should not trigger the gate; issue 26840
+}
i += 1;
}
}
-
-fn quy() {
- let i = -23_usize; //~ WARNING negation of unsigned int literal may be unintentional
- //~^ WARNING unused variable
-}
-
-fn quz() {
- let i = 23_usize;
- let j = -i; //~ WARNING negation of unsigned int variable may be unintentional
- //~^ WARNING unused variable
-}
projects / rust.git / commitdiff