Fixes #25826.
E0316, // nested quantification of lifetimes
E0370, // discriminant overflow
E0378, // method calls limited to constant inherent methods
- E0394 // cannot refer to other statics by value, use the address-of
+ E0394, // cannot refer to other statics by value, use the address-of
// operator or a constant instead
+ E0395, // pointer comparison in const-expr
+ E0396 // pointer dereference in const-expr
}
"allocations are not allowed in {}s", v.msg());
}
}
- ast::ExprUnary(ast::UnDeref, ref ptr) => {
- match ty::node_id_to_type(v.tcx, ptr.id).sty {
+ ast::ExprUnary(op, ref inner) => {
+ match ty::node_id_to_type(v.tcx, inner.id).sty {
ty::ty_ptr(_) => {
- // This shouldn't be allowed in constants at all.
+ assert!(op == ast::UnDeref);
+
+ v.add_qualif(ConstQualif::NOT_CONST);
+ if v.mode != Mode::Var {
+ span_err!(v.tcx.sess, e.span, E0396,
+ "raw pointers cannot be dereferenced in {}s", v.msg());
+ }
+ }
+ _ => {}
+ }
+ }
+ ast::ExprBinary(op, ref lhs, _) => {
+ match ty::node_id_to_type(v.tcx, lhs.id).sty {
+ ty::ty_ptr(_) => {
+ assert!(op.node == ast::BiEq || op.node == ast::BiNe ||
+ op.node == ast::BiLe || op.node == ast::BiLt ||
+ op.node == ast::BiGe || op.node == ast::BiGt);
+
v.add_qualif(ConstQualif::NOT_CONST);
+ if v.mode != Mode::Var {
+ span_err!(v.tcx.sess, e.span, E0395,
+ "raw pointers cannot be compared in {}s", v.msg());
+ }
}
_ => {}
}
v.add_qualif(ConstQualif::NOT_CONST);
if v.mode != Mode::Var {
span_err!(v.tcx.sess, e.span, E0018,
- "can't cast a pointer to an integer in {}s", v.msg());
+ "raw pointers cannot be cast to integers in {}s", v.msg());
}
}
_ => {}
}
ast::ExprBlock(_) |
- ast::ExprUnary(..) |
- ast::ExprBinary(..) |
ast::ExprIndex(..) |
ast::ExprField(..) |
ast::ExprTupField(..) |
--- /dev/null
+// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
+// file at the top-level directory of this distribution and at
+// http://rust-lang.org/COPYRIGHT.
+//
+// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
+// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
+// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
+// option. This file may not be copied, modified, or distributed
+// except according to those terms.
+
+// Check that you can't dereference raw pointers in constants.
+
+fn main() {
+ static C: u64 = unsafe {*(0xdeadbeef as *const u64)}; //~ ERROR E0396
+ println!("{}", C);
+}
// except according to those terms.
static X: usize = 0 as *const usize as usize;
-//~^ ERROR: can't cast a pointer to an integer in statics
+//~^ ERROR: raw pointers cannot be cast to integers in statics
fn main() {
assert_eq!(X, 0);
--- /dev/null
+// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
+// file at the top-level directory of this distribution and at
+// http://rust-lang.org/COPYRIGHT.
+//
+// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
+// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
+// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
+// option. This file may not be copied, modified, or distributed
+// except according to those terms.
+
+fn id<T>(t: T) -> T { t }
+fn main() {
+ const A: bool = id::<u8> as *const () < id::<u16> as *const ();
+ //~^ ERROR raw pointers cannot be compared in constants [E0395]
+ println!("{}", A);
+}