]> git.lizzy.rs Git - rust.git/commitdiff
minor: Remove unnecessary clones
authorLukas Wirth <lukastw97@gmail.com>
Sat, 11 Dec 2021 14:27:36 +0000 (15:27 +0100)
committerLukas Wirth <lukastw97@gmail.com>
Sat, 11 Dec 2021 14:27:36 +0000 (15:27 +0100)
crates/ide_db/src/helpers/import_assets.rs

index 024e0c9f81f497f7dd68a0dff1d52159315bad48..291675c4cc0c590d41f72943b19407d016fa9156 100644 (file)
@@ -280,7 +280,7 @@ fn search_for(
         .into_iter()
         .filter(|import| import.import_path.len() > 1)
         .filter(|import| !scope_definitions.contains(&ScopeDef::from(import.item_to_import)))
-        .sorted_by_key(|import| import.import_path.clone())
+        .sorted_by(|a, b| a.import_path.cmp(&b.import_path))
         .collect()
     }
 
@@ -309,9 +309,9 @@ fn path_applicable_imports(
                 current_crate,
                 path_candidate.name.clone(),
                 // FIXME: we could look up assoc items by the input and propose those in completion,
-                // but that requries more preparation first:
+                // but that requires more preparation first:
                 // * store non-trait assoc items in import_map to fully enable this lookup
-                // * ensure that does not degrade the performance (bencmark it)
+                // * ensure that does not degrade the performance (benchmark it)
                 // * write more logic to check for corresponding trait presence requirement (we're unable to flyimport multiple item right now)
                 // * improve the associated completion item matching and/or scoring to ensure no noisy completions appear
                 //