]> git.lizzy.rs Git - rust.git/commitdiff
Allow negative impls just for Send and Sync
authorFlavio Percoco <flaper87@gmail.com>
Mon, 12 Jan 2015 09:59:22 +0000 (10:59 +0100)
committerFlavio Percoco <flaper87@gmail.com>
Fri, 16 Jan 2015 07:18:56 +0000 (08:18 +0100)
src/librustc_typeck/check/wf.rs
src/test/compile-fail/typeck-negative-impls-builtin.rs [new file with mode: 0644]

index baa4850ce4a3e2df65fb46b3ae2638178ce7488f..e6390212c6002ca09d726ac418be058dfef8c704 100644 (file)
@@ -76,6 +76,18 @@ fn check_item_well_formed(&mut self, item: &ast::Item) {
             ast::ItemImpl(_, ast::ImplPolarity::Positive, _, _, _, _) => {
                 self.check_impl(item);
             }
+            ast::ItemImpl(_, ast::ImplPolarity::Negative, _, Some(ref tref), _, _) => {
+                let trait_ref = ty::node_id_to_trait_ref(ccx.tcx, tref.ref_id);
+                match ccx.tcx.lang_items.to_builtin_kind(trait_ref.def_id) {
+                    Some(ty::BoundSend) | Some(ty::BoundSync) => {}
+                    Some(_) | None => {
+                        ccx.tcx.sess.span_err(
+                            item.span,
+                            format!("negative impls are currently \
+                                     allowed just for `Send` and `Sync`").as_slice())
+                    }
+                }
+            }
             ast::ItemFn(..) => {
                 self.check_item_type(item);
             }
diff --git a/src/test/compile-fail/typeck-negative-impls-builtin.rs b/src/test/compile-fail/typeck-negative-impls-builtin.rs
new file mode 100644 (file)
index 0000000..9da79b1
--- /dev/null
@@ -0,0 +1,20 @@
+// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
+// file at the top-level directory of this distribution and at
+// http://rust-lang.org/COPYRIGHT.
+//
+// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
+// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
+// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
+// option. This file may not be copied, modified, or distributed
+// except according to those terms.
+
+#![feature(optin_builtin_traits)]
+
+struct TestType;
+
+trait TestTrait {}
+
+impl !TestTrait for TestType {}
+//~^ ERROR  negative impls are currently allowed just for `Send` and `Sync`
+
+fn main() {}