Trigger on_rightclick regardless on the formspec meta field

Document behaviour for older clients.

diff --git a/doc/lua_api.txt b/doc/lua_api.txt
index aefcba064920773f5f6daa000f21d7df0853cac6..edef755938c9df1f04ce239796aa24cae2d10a32 100644 (file)
--- a/doc/lua_api.txt
+++ b/doc/lua_api.txt
@@ -4261,9 +4261,11 @@ Definition tables
         ^ By default: Calls minetest.register_on_punchnode callbacks ]]
         on_rightclick = func(pos, node, clicker, itemstack, pointed_thing), --[[
         ^ default: nil
-        ^ if defined, itemstack will hold clicker's wielded item
+        ^ itemstack will hold clicker's wielded item
         ^ Shall return the leftover itemstack
-        ^ Note: pointed_thing can be nil, if a mod calls this function ]]
+        ^ Note: pointed_thing can be nil, if a mod calls this function
+          This function does not get triggered by clients <=0.4.16 if the
+          "formspec" node metadata field is set ]]
 
         on_dig = func(pos, node, digger), --[[
         ^ default: minetest.node_dig

diff --git a/src/game.cpp b/src/game.cpp
index 8958826ad879f29b02dfd4e8cbcc3c46941b87b1..68acc81b7400dbcf2586c009c9781f0b35748240 100644 (file)
--- a/src/game.cpp
+++ b/src/game.cpp
@@ -3801,6 +3801,11 @@ void Game::handlePointingAtNode(const PointedThing &pointed,
 
                if (meta && meta->getString("formspec") != "" && !random_input
                                && !isKeyDown(KeyType::SNEAK)) {
+                       // Report right click to server
+                       if (nodedef_manager->get(map.getNodeNoEx(nodepos)).rightclickable) {
+                               client->interact(3, pointed);
+                       }
+
                        infostream << "Launching custom inventory view" << std::endl;
 
                        InventoryLocation inventoryloc;