]> git.lizzy.rs Git - rust.git/commitdiff
pprust: Fix asm options
authorklutzy <klutzytheklutzy@gmail.com>
Wed, 17 Dec 2014 13:02:50 +0000 (22:02 +0900)
committerklutzy <klutzytheklutzy@gmail.com>
Mon, 22 Dec 2014 04:37:10 +0000 (13:37 +0900)
src/libsyntax/print/pprust.rs
src/test/pretty/asm-options.rs [new file with mode: 0644]

index a9717a526ad9db6cb28327ec56cc97d5df7c0e25..66ef7a9aee114ea5af39a8139e95d8dc990dbd54 100644 (file)
@@ -1786,11 +1786,7 @@ pub fn print_expr(&mut self, expr: &ast::Expr) -> IoResult<()> {
                 }
             }
             ast::ExprInlineAsm(ref a) => {
-                if a.volatile {
-                    try!(word(&mut self.s, "__volatile__ asm!"));
-                } else {
-                    try!(word(&mut self.s, "asm!"));
-                }
+                try!(word(&mut self.s, "asm!"));
                 try!(self.popen());
                 try!(self.print_string(a.asm.get(), a.asm_str_style));
                 try!(self.word_space(":"));
@@ -1828,6 +1824,28 @@ pub fn print_expr(&mut self, expr: &ast::Expr) -> IoResult<()> {
                     try!(s.print_string(co.get(), ast::CookedStr));
                     Ok(())
                 }));
+
+                let mut options = vec!();
+                if a.volatile {
+                    options.push("volatile");
+                }
+                if a.alignstack {
+                    options.push("alignstack");
+                }
+                if a.dialect == ast::AsmDialect::AsmIntel {
+                    options.push("intel");
+                }
+
+                if options.len() > 0 {
+                    try!(space(&mut self.s));
+                    try!(self.word_space(":"));
+                    try!(self.commasep(Inconsistent, &*options,
+                                       |s, &co| {
+                        try!(s.print_string(co, ast::CookedStr));
+                        Ok(())
+                    }));
+                }
+
                 try!(self.pclose());
             }
             ast::ExprMac(ref m) => try!(self.print_mac(m, token::Paren)),
diff --git a/src/test/pretty/asm-options.rs b/src/test/pretty/asm-options.rs
new file mode 100644 (file)
index 0000000..bc9f89a
--- /dev/null
@@ -0,0 +1,21 @@
+// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
+// file at the top-level directory of this distribution and at
+// http://rust-lang.org/COPYRIGHT.
+//
+// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
+// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
+// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
+// option. This file may not be copied, modified, or distributed
+// except according to those terms.
+
+#![feature(asm)]
+
+// pp-exact
+
+pub fn main() {
+    unsafe {
+        asm!("" : : : : "volatile");
+        asm!("" : : : : "alignstack");
+        asm!("" : : : : "intel");
+    }
+}