]> git.lizzy.rs Git - rust.git/commitdiff
Fix false positives in assignment inside the else condition
authorZaki Manian <zaki@manian.org>
Sun, 3 Sep 2017 15:31:15 +0000 (08:31 -0700)
committerZaki Manian <zaki@manian.org>
Sun, 3 Sep 2017 15:31:15 +0000 (08:31 -0700)
clippy_lints/src/is_unit_expr.rs

index be6a750fec921d51ee39a45b57474b1d0599d672..82460f82fa126881a908ba2c7d3257998b1b2083 100644 (file)
@@ -84,14 +84,12 @@ fn is_unit_expr(expr: &Expr) -> Option<Span> {
                 let check_else = is_unit_expr(else_.deref());
                 if let Some(ref expr_else) = check_else {
                     return Some(expr_else.clone());
-                } else {
-                    return Some(expr.span.clone());
-                }
+                } 
             }
             if check_then {
                 return Some(expr.span.clone());
             } else {
-                return Some(expr.span.clone());
+                return None;
             }
         },
         ExprKind::Match(ref _pattern, ref arms) => {