]> git.lizzy.rs Git - rust.git/commitdiff
Remove FIXME
authorbjorn3 <bjorn3@users.noreply.github.com>
Sat, 16 Nov 2019 15:54:47 +0000 (16:54 +0100)
committerbjorn3 <bjorn3@users.noreply.github.com>
Sat, 16 Nov 2019 15:54:47 +0000 (16:54 +0100)
src/cast.rs

index 870c316f41d3b551f68a5e787693ca16d079d2b8..d945ad7d054bfcf9a5216b2abb80a03289c40dd2 100644 (file)
@@ -63,7 +63,9 @@ pub fn clif_int_or_float_cast(
             fx,
             from,
             to_ty,
-            from_signed, // FIXME is this correct?
+            // This is correct as either from_signed == to_signed (=> this is trivially correct)
+            // Or from_clif_ty == to_clif_ty, which means this is a no-op.
+            from_signed,
         )
     } else if from_ty.is_int() && to_ty.is_float() {
         if from_ty == types::I128 {