]> git.lizzy.rs Git - rust.git/commitdiff
0-length arrays can even be mutably promoted
authorOliver Schneider <github35764891676564198441@oli-obk.de>
Tue, 24 Jul 2018 18:47:53 +0000 (20:47 +0200)
committerOliver Schneider <github35764891676564198441@oli-obk.de>
Wed, 25 Jul 2018 12:09:06 +0000 (14:09 +0200)
src/librustc_mir/borrow_check/mod.rs
src/test/ui/const-eval/promote_mutable_zst_mir_borrowck.rs [new file with mode: 0644]

index b3d7337cffe115b43ef5db31d68bcbf0a76b8dae..84e3ecd509687cba5a3dfc9fcded7513656cbf49 100644 (file)
@@ -1864,8 +1864,12 @@ fn is_mutable<'d>(
                     }),
                 }
             }
-            // promoteds may never be mutated
-            Place::Promoted(_) => bug!("encountered mutable promoted"),
+            // The rules for promotion are made by `qualify_consts`, there wouldn't even be a
+            // `Place::Promoted` if the promotion weren't 100% legal. So we just forward this
+            Place::Promoted(_) => Ok(RootPlace {
+                place,
+                is_local_mutation_allowed,
+            }),
             Place::Static(ref static_) => {
                 if self.tcx.is_static(static_.def_id) != Some(hir::Mutability::MutMutable) {
                     Err(place)
diff --git a/src/test/ui/const-eval/promote_mutable_zst_mir_borrowck.rs b/src/test/ui/const-eval/promote_mutable_zst_mir_borrowck.rs
new file mode 100644 (file)
index 0000000..922d7d3
--- /dev/null
@@ -0,0 +1,17 @@
+// Copyright 2018 The Rust Project Developers. See the COPYRIGHT
+// file at the top-level directory of this distribution and at
+// http://rust-lang.org/COPYRIGHT.
+//
+// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
+// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
+// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
+// option. This file may not be copied, modified, or distributed
+// except according to those terms.
+
+// compile-pass
+
+#![feature(nll)]
+
+pub fn main() {
+    let y: &'static mut [u8; 0] = &mut [];
+}