Simplify error message producing & remove extra example
- diag.span_help(i.pat.span, &format!("consider refactoring into `{} | {}`", lhs, rhs));
+ diag.span_help(i.pat.span, &format!("consider refactoring into `{} | {}`", lhs, rhs,))
+ .help("...or consider changing the match arm bodies");
|
LL | (1, .., 3) => 42,
| ^^^^^^^^^^
|
LL | (1, .., 3) => 42,
| ^^^^^^^^^^
+ = help: ...or consider changing the match arm bodies
error: this `match` has identical arm bodies
--> $DIR/match_same_arms.rs:24:15
error: this `match` has identical arm bodies
--> $DIR/match_same_arms.rs:24:15
+ = help: ...or consider changing the match arm bodies
error: this `match` has identical arm bodies
--> $DIR/match_same_arms.rs:26:15
error: this `match` has identical arm bodies
--> $DIR/match_same_arms.rs:26:15
+ = help: ...or consider changing the match arm bodies
error: this `match` has identical arm bodies
--> $DIR/match_same_arms.rs:32:14
error: this `match` has identical arm bodies
--> $DIR/match_same_arms.rs:32:14
+ = help: ...or consider changing the match arm bodies
error: this `match` has identical arm bodies
--> $DIR/match_same_arms.rs:33:14
error: this `match` has identical arm bodies
--> $DIR/match_same_arms.rs:33:14
+ = help: ...or consider changing the match arm bodies
error: this `match` has identical arm bodies
--> $DIR/match_same_arms.rs:33:14
error: this `match` has identical arm bodies
--> $DIR/match_same_arms.rs:33:14
|
LL | 2 => 2, //~ ERROR 2nd matched arms have same body
| ^
|
LL | 2 => 2, //~ ERROR 2nd matched arms have same body
| ^
+ = help: ...or consider changing the match arm bodies
error: this `match` has identical arm bodies
--> $DIR/match_same_arms.rs:50:55
error: this `match` has identical arm bodies
--> $DIR/match_same_arms.rs:50:55
|
LL | CommandInfo::BuiltIn { name, .. } => name.to_string(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
LL | CommandInfo::BuiltIn { name, .. } => name.to_string(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+ = help: ...or consider changing the match arm bodies
error: aborting due to 8 previous errors
error: aborting due to 8 previous errors
+ = help: ...or consider changing the match arm bodies
error: this `match` has identical arm bodies
--> $DIR/match_same_arms2.rs:40:17
error: this `match` has identical arm bodies
--> $DIR/match_same_arms2.rs:40:17
|
LL | Some(_) => 24,
| ^^^^^^^
|
LL | Some(_) => 24,
| ^^^^^^^
+ = help: ...or consider changing the match arm bodies
error: this `match` has identical arm bodies
--> $DIR/match_same_arms2.rs:62:28
error: this `match` has identical arm bodies
--> $DIR/match_same_arms2.rs:62:28
|
LL | (Some(a), None) => bar(a),
| ^^^^^^^^^^^^^^^
|
LL | (Some(a), None) => bar(a),
| ^^^^^^^^^^^^^^^
+ = help: ...or consider changing the match arm bodies
error: this `match` has identical arm bodies
--> $DIR/match_same_arms2.rs:68:26
error: this `match` has identical arm bodies
--> $DIR/match_same_arms2.rs:68:26
|
LL | (Some(a), ..) => bar(a),
| ^^^^^^^^^^^^^
|
LL | (Some(a), ..) => bar(a),
| ^^^^^^^^^^^^^
+ = help: ...or consider changing the match arm bodies
error: this `match` has identical arm bodies
--> $DIR/match_same_arms2.rs:102:29
error: this `match` has identical arm bodies
--> $DIR/match_same_arms2.rs:102:29
|
LL | (Ok(x), Some(_)) => println!("ok {}", x),
| ^^^^^^^^^^^^^^^^
|
LL | (Ok(x), Some(_)) => println!("ok {}", x),
| ^^^^^^^^^^^^^^^^
+ = help: ...or consider changing the match arm bodies
= note: this error originates in the macro `println` (in Nightly builds, run with -Z macro-backtrace for more info)
error: this `match` has identical arm bodies
= note: this error originates in the macro `println` (in Nightly builds, run with -Z macro-backtrace for more info)
error: this `match` has identical arm bodies
|
LL | Ok(3) => println!("ok"),
| ^^^^^
|
LL | Ok(3) => println!("ok"),
| ^^^^^
+ = help: ...or consider changing the match arm bodies
= note: this error originates in the macro `println` (in Nightly builds, run with -Z macro-backtrace for more info)
error: this `match` has identical arm bodies
= note: this error originates in the macro `println` (in Nightly builds, run with -Z macro-backtrace for more info)
error: this `match` has identical arm bodies
+ = help: ...or consider changing the match arm bodies
error: match expression looks like `matches!` macro
--> $DIR/match_same_arms2.rs:162:16
error: match expression looks like `matches!` macro
--> $DIR/match_same_arms2.rs:162:16