git.lizzy.rs Git - rust.git/commit

]> git.lizzy.rs Git - rust.git/commit

author	Matthew Jasper <mjjasper1@gmail.com>
	Wed, 1 Sep 2021 21:52:17 +0000 (22:52 +0100)
committer	Matthew Jasper <mjjasper1@gmail.com>
	Wed, 1 Sep 2021 22:47:41 +0000 (23:47 +0100)
commit	ff8c0ef0e47639b32fdba062851a1367a9cc9ae2
tree	65030b964b24d8c0ccaf02bd00f475bb09dfd179	tree \| snapshot
parent	50171c310cd15e1b2d3723766ce64e2e4d6696fc	commit \| diff

Fix drop handling for `if let` expressions

MIR lowering for `if let` expressions is now more complicated now that
`if let` exists in HIR. This PR adds a scope for the variables bound in
an `if let` expression and then uses an approach similar to how we
handle loops to ensure that we reliably drop the correct variables.

56 files changed:

compiler/rustc_hir/src/hir.rs		diff \| blob \| history
compiler/rustc_middle/src/middle/region.rs		diff \| blob \| history
compiler/rustc_middle/src/thir.rs		diff \| blob \| history
compiler/rustc_mir_build/src/build/expr/into.rs		diff \| blob \| history
compiler/rustc_mir_build/src/build/matches/mod.rs		diff \| blob \| history
compiler/rustc_mir_build/src/build/scope.rs		diff \| blob \| history
compiler/rustc_mir_build/src/thir/cx/expr.rs		diff \| blob \| history
compiler/rustc_mir_build/src/thir/visit.rs		diff \| blob \| history
compiler/rustc_passes/src/region.rs		diff \| blob \| history
src/test/mir-opt/bool_compare.opt1.InstCombine.diff		diff \| blob \| history
src/test/mir-opt/bool_compare.opt2.InstCombine.diff		diff \| blob \| history
src/test/mir-opt/bool_compare.opt3.InstCombine.diff		diff \| blob \| history
src/test/mir-opt/bool_compare.opt4.InstCombine.diff		diff \| blob \| history
src/test/mir-opt/const_goto.issue_77355_opt.ConstGoto.diff		diff \| blob \| history
src/test/mir-opt/const_prop/control_flow_simplification.hello.ConstProp.diff		diff \| blob \| history
src/test/mir-opt/const_prop/discriminant.main.ConstProp.64bit.diff		diff \| blob \| history
src/test/mir-opt/deaggregator_test_enum_2.test1.Deaggregator.diff		diff \| blob \| history
src/test/mir-opt/dest-prop/branch.main.DestinationPropagation.diff		diff \| blob \| history
src/test/mir-opt/equal_true.opt.InstCombine.diff		diff \| blob \| history
src/test/mir-opt/funky_arms.float_to_exponential_common.ConstProp.diff		diff \| blob \| history
src/test/mir-opt/if_condition_int.dont_opt_bool.SimplifyComparisonIntegral.diff		diff \| blob \| history
src/test/mir-opt/if_condition_int.dont_opt_floats.SimplifyComparisonIntegral.diff		diff \| blob \| history
src/test/mir-opt/if_condition_int.opt_char.SimplifyComparisonIntegral.diff		diff \| blob \| history
src/test/mir-opt/if_condition_int.opt_i8.SimplifyComparisonIntegral.diff		diff \| blob \| history
src/test/mir-opt/if_condition_int.opt_multiple_ifs.SimplifyComparisonIntegral.diff		diff \| blob \| history
src/test/mir-opt/if_condition_int.opt_negative.SimplifyComparisonIntegral.diff		diff \| blob \| history
src/test/mir-opt/if_condition_int.opt_u32.SimplifyComparisonIntegral.diff		diff \| blob \| history
src/test/mir-opt/inline/inline_diverging.g.Inline.diff		diff \| blob \| history
src/test/mir-opt/issue_38669.main.SimplifyCfg-initial.after.mir		diff \| blob \| history
src/test/mir-opt/issue_41888.main.ElaborateDrops.after.mir		diff \| blob \| history
src/test/mir-opt/issues/issue_59352.num_to_digit.PreCodegen.after.mir		diff \| blob \| history
src/test/mir-opt/issues/issue_75439.foo.MatchBranchSimplification.diff		diff \| blob \| history
src/test/mir-opt/loop_test.main.SimplifyCfg-promote-consts.after.mir		diff \| blob \| history
src/test/mir-opt/lower_slice_len.bound.LowerSliceLenCalls.diff		diff \| blob \| history
src/test/mir-opt/match_arm_scopes.complicated_match.SimplifyCfg-initial.after-ElaborateDrops.after.diff		diff \| blob \| history
src/test/mir-opt/match_false_edges.full_tested_match.PromoteTemps.after.mir		diff \| blob \| history
src/test/mir-opt/match_false_edges.full_tested_match2.PromoteTemps.before.mir		diff \| blob \| history
src/test/mir-opt/match_false_edges.main.PromoteTemps.before.mir		diff \| blob \| history
src/test/mir-opt/match_test.main.SimplifyCfg-initial.after.mir		diff \| blob \| history
src/test/mir-opt/matches_reduce_branches.match_nested_if.MatchBranchSimplification.64bit.diff		diff \| blob \| history
src/test/mir-opt/nll/region_subtyping_basic.main.nll.0.64bit.mir		diff \| blob \| history
src/test/mir-opt/not_equal_false.opt.InstCombine.diff		diff \| blob \| history
src/test/mir-opt/remove_fake_borrows.match_guard.CleanupNonCodegenStatements.diff		diff \| blob \| history
src/test/mir-opt/simplify_cfg.main.SimplifyCfg-early-opt.diff		diff \| blob \| history
src/test/mir-opt/simplify_cfg.main.SimplifyCfg-initial.diff		diff \| blob \| history
src/test/mir-opt/simplify_if.main.SimplifyBranches-after-const-prop.diff		diff \| blob \| history
src/test/mir-opt/simplify_locals_fixedpoint.foo.SimplifyLocals.diff		diff \| blob \| history
src/test/mir-opt/unreachable.main.UnreachablePropagation.diff		diff \| blob \| history
src/test/mir-opt/unreachable_asm.main.UnreachablePropagation.diff		diff \| blob \| history
src/test/mir-opt/unreachable_asm_2.main.UnreachablePropagation.diff		diff \| blob \| history
src/test/mir-opt/unreachable_diverging.main.UnreachablePropagation.diff		diff \| blob \| history
src/test/mir-opt/while_let_loops.change_loop_body.ConstProp.64bit.diff		diff \| blob \| history
src/test/mir-opt/while_storage.while_loop.PreCodegen.after.mir		diff \| blob \| history
src/test/ui/consts/const-eval/infinite_loop.stderr		diff \| blob \| history
src/test/ui/consts/const_limit/const_eval_limit_reached.stderr		diff \| blob \| history
src/test/ui/drop/drop-if-let-binding.rs	[new file with mode: 0644]	blob

Empowering everyone to build reliable and efficient software.

RSS Atom