]> git.lizzy.rs Git - rust.git/commit
Rollup merge of #42092 - cuviper:args_os, r=Mark-Simulacrum
authorMark Simulacrum <mark.simulacrum@gmail.com>
Fri, 19 May 2017 20:16:24 +0000 (14:16 -0600)
committerGitHub <noreply@github.com>
Fri, 19 May 2017 20:16:24 +0000 (14:16 -0600)
commitfd8ca3ea6d9dbd09336f882ec9a2952a752954b5
tree378a1d370dedb584c0f657ad6bc218d9077c92f6
parent7812adf1ee3b410ca367958f0d7275992982b031
parente86588e2286ac2c0fb4763bf2d8c3046d0abcc22
Rollup merge of #42092 - cuviper:args_os, r=Mark-Simulacrum

Give a nicer error for non-Unicode arguments to rustc and rustdoc

Previously, any non-Unicode argument would panic rustc:

```
$ rustc $'foo\x80bar'
error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report:
https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports

thread 'rustc' panicked at 'called `Result::unwrap()` on an `Err` value:
"foo�bar"', /checkout/src/libcore/result.rs:859 note: Run with
`RUST_BACKTRACE=1` for a backtrace.
```

Now it gives a clean error:

```
$ rustc $'foo\x80bar'
error: Argument 1 is not valid Unicode: "foo�bar"
```

Maybe fixes #15890, although we still can't *compile* arbitrary file names.