]> git.lizzy.rs Git - rust.git/commit
Pass -fPIC to native compiles on 32-bit
authorAlex Crichton <alex@alexcrichton.com>
Sat, 4 Feb 2017 06:18:32 +0000 (22:18 -0800)
committerAlex Crichton <alex@alexcrichton.com>
Sat, 4 Feb 2017 06:18:32 +0000 (22:18 -0800)
commitf98f6c717a6e709b9f0edd3cf0ea4f18e2ca9767
treebe7381585575d9cb64d8632876fbe4e221d13cf2
parentc781fc4a6a8af287f7abe141f035a638bc0165c3
Pass -fPIC to native compiles on 32-bit

This is apparently a regression from 1.14.0 to 1.15.0. Previously we
passed `-fPIC` to C compilers on i686 targets, but the `gcc` crate
apparently [explicitly] didn't do this. I don't recall why that was
avoided but it was [previously passed by the makefiles][mk] and this
seems to have [caused a regression][regression] in Firefox, so this
commit reverts back to passing `-fPIC`.

[explicitly]: https://github.com/alexcrichton/gcc-rs/commit/362bdf20
[mk]: https://github.com/rust-lang/rust/blob/c781fc4a/mk/cfg/i686-unknown-linux-gnu.mk#L11
[regression]: https://bugzilla.mozilla.org/show_bug.cgi?id=1336155
12 files changed:
src/Cargo.lock
src/vendor/gcc/.cargo-checksum.json
src/vendor/gcc/.gitignore
src/vendor/gcc/.travis.yml
src/vendor/gcc/Cargo.toml
src/vendor/gcc/README.md
src/vendor/gcc/src/bin/gcc-shim.rs
src/vendor/gcc/src/lib.rs
src/vendor/gcc/src/registry.rs
src/vendor/gcc/src/windows_registry.rs
src/vendor/gcc/tests/support/mod.rs
src/vendor/gcc/tests/test.rs