]> git.lizzy.rs Git - rust.git/commit
back out bogus `Ok`-wrapping suggestion on `?` arm type mismatch
authorZack M. Davis <code@zackmdavis.net>
Sat, 27 Oct 2018 21:55:07 +0000 (14:55 -0700)
committerZack M. Davis <code@zackmdavis.net>
Sat, 27 Oct 2018 21:55:07 +0000 (14:55 -0700)
commitb7546150b2f372bc31f908c41c0078936c3d8b66
tree33978144e1288fc471445ca7884f13d980873a2e
parentf32f1113c93fe84f252293ae4af86be1ceae4a84
back out bogus `Ok`-wrapping suggestion on `?` arm type mismatch

This suggestion was introduced in #51938 / 6cc78bf8d7 (while
introducing different language for type errors coming from `?` rather
than a `match`), but it has a lot of false-positives (as repeatedly
reported in Issues #52537, #52598, #54578, #55336), and incorrect
suggestions carry more badness than marginal good suggestions do
goodness. Just get rid of it (unless and until someone figures out how
to do it correctly).

Resolves #52537, resolves #54578.
src/librustc/infer/error_reporting/mod.rs
src/test/ui/issues/issue-51632-try-desugar-incompatible-types.fixed [deleted file]
src/test/ui/issues/issue-51632-try-desugar-incompatible-types.rs
src/test/ui/issues/issue-51632-try-desugar-incompatible-types.stderr