]> git.lizzy.rs Git - rust.git/commit
introduce future-compatibility warning for forbidden lint groups
authorNiko Matsakis <niko@alum.mit.edu>
Sat, 30 Jan 2021 00:06:00 +0000 (19:06 -0500)
committerNiko Matsakis <niko@alum.mit.edu>
Tue, 2 Feb 2021 23:21:37 +0000 (18:21 -0500)
commitb6b897b02c080759ec365d440d5df7cf93426657
tree2e8f6b40ba4321aeeb7b59f9809617b14f35eca3
parentc0b64d97beebb09325b5587abed39f4f1621026f
introduce future-compatibility warning for forbidden lint groups

We used to ignore `forbid(group)` scenarios completely. This changed
in #78864, but that led to a number of regressions (#80988, #81218).

This PR introduces a future compatibility warning for the case where
a group is forbidden but then an individual lint within that group
is allowed. We now issue a FCW when we see the "allow", but permit
it to take effect.
19 files changed:
compiler/rustc_lint/src/context.rs
compiler/rustc_lint/src/levels.rs
compiler/rustc_lint_defs/src/builtin.rs
compiler/rustc_middle/src/lint.rs
src/test/ui/lint/forbid-group-group-1.rs [new file with mode: 0644]
src/test/ui/lint/forbid-group-group-1.stderr [new file with mode: 0644]
src/test/ui/lint/forbid-group-group-2.rs [new file with mode: 0644]
src/test/ui/lint/forbid-group-group-2.stderr [new file with mode: 0644]
src/test/ui/lint/forbid-group-member.rs [new file with mode: 0644]
src/test/ui/lint/forbid-group-member.stderr [new file with mode: 0644]
src/test/ui/lint/forbid-member-group.rs [new file with mode: 0644]
src/test/ui/lint/forbid-member-group.stderr [new file with mode: 0644]
src/test/ui/lint/issue-70819-dont-override-forbid-in-same-scope.rs
src/test/ui/lint/issue-70819-dont-override-forbid-in-same-scope.stderr
src/test/ui/lint/issue-80988.rs [new file with mode: 0644]
src/test/ui/lint/issue-80988.stderr [new file with mode: 0644]
src/test/ui/lint/issue-81218.rs [new file with mode: 0644]
src/test/ui/lint/outer-forbid.rs
src/test/ui/lint/outer-forbid.stderr