]> git.lizzy.rs Git - rust.git/commit
Rollup merge of #42144 - cengizIO:master, r=nikomatsakis
authorCorey Farwell <coreyf@rwell.org>
Tue, 23 May 2017 04:15:43 +0000 (00:15 -0400)
committerGitHub <noreply@github.com>
Tue, 23 May 2017 04:15:43 +0000 (00:15 -0400)
commit9739e8dbc9e65a7ccbba65d987c0491804796c7b
treec90fc9241b1b9210220e962137af21c54c8762ce
parent7a7e2360765e5ce2eb0ad5da409da24f440dc68f
parent9111d07a6ea8dad2685e8d39bffd654f231a24c2
Rollup merge of #42144 - cengizIO:master, r=nikomatsakis

make ui test output patch compatible #41948

Hello!

Previously with #41474 I've changed the internals of UI test output comparison mechanism.

That change didn't change the diff format that we were producing but we needed to improve it anyway.

This makes unified diff lines a little bit more `patch` compatible.

Also I tried to introduce a unit test to check this but couldn't decide which of the following to implement:

1. Should I replace `println` macros with `Writer`s? And access the produced output within a test?
2. Should I add an external test (something like `src/test/run-pass/command-exec.rs`)
3. There are crates that capture `stdout`. Are they safe to use here? (I don't think so)

Thanks!

cc @nikomatsakis