]> git.lizzy.rs Git - rust.git/commit
Auto merge of #103556 - clubby789:specialize-option-partial-eq, r=scottmcm
authorbors <bors@rust-lang.org>
Sat, 26 Nov 2022 08:56:20 +0000 (08:56 +0000)
committerbors <bors@rust-lang.org>
Sat, 26 Nov 2022 08:56:20 +0000 (08:56 +0000)
commit8841bee954ecf0e6820c9990feb3a76cb04e7d96
tree33cdcb23858966c692ec79816aaf6ca593b9eaca
parentf8a2e491ebec34113563cf8683f6fec2646cebb1
parentb9a95d89902a6c9ba17dae21d84c2c04454bdddd
Auto merge of #103556 - clubby789:specialize-option-partial-eq, r=scottmcm

Manually implement PartialEq for Option<T> and specialize non-nullable types

This PR manually implements `PartialEq` and `StructuralPartialEq` for `Option`, which seems to produce slightly better codegen than the automatically derived implementation.

It also allows specializing on the `core::num::NonZero*` and `core::ptr::NonNull` types, taking advantage of the niche optimization by transmuting the `Option<T>` to `T` to be compared directly, which can be done in just two instructions.

A comparison of the original, new and specialized code generation is available [here](https://godbolt.org/z/dE4jxdYsa).
compiler/rustc_macros/src/lib.rs
library/core/src/option.rs