]> git.lizzy.rs Git - rust.git/commit
Reword malformed attribute input diagnostics
authorEsteban Küber <esteban@kuber.com.ar>
Wed, 22 May 2019 00:47:23 +0000 (17:47 -0700)
committerEsteban Küber <esteban@kuber.com.ar>
Sat, 25 May 2019 18:55:50 +0000 (11:55 -0700)
commit609ffa1a890fd6b8b0364cd7b35bf1d45abf82d0
treedbd09e2fa625c27c100cb21e6b196c9f45b5ec27
parent02f5786a324c40b2d8b2d0df98456e48fb45d30c
Reword malformed attribute input diagnostics

- Handle empty `cfg_attr` attribute
- Reword empty `derive` attribute error
- Use consistend error message: "malformed `attrname` attribute input"
- Provide suggestions when possible
- Move note/help to label/suggestion
- Use consistent wording "ill-formed" -> "malformed"
- Move diagnostic logic out of parser
55 files changed:
src/librustc/lint/levels.rs
src/librustc_plugin/load.rs
src/librustc_typeck/collect.rs
src/libsyntax/attr/builtin.rs
src/libsyntax/config.rs
src/libsyntax/ext/derive.rs
src/libsyntax/feature_gate.rs
src/test/ui/deprecation/deprecated_no_stack_check.stderr
src/test/ui/deprecation/invalid-literal.rs
src/test/ui/deprecation/invalid-literal.stderr
src/test/ui/error-codes/E0452.stderr
src/test/ui/feature-gate/issue-43106-gating-of-macro_use.rs
src/test/ui/feature-gate/issue-43106-gating-of-macro_use.stderr
src/test/ui/gated-bad-feature.rs
src/test/ui/gated-bad-feature.stderr
src/test/ui/invalid_crate_type_syntax.rs
src/test/ui/invalid_crate_type_syntax.stderr
src/test/ui/issues/issue-43988.rs
src/test/ui/issues/issue-43988.stderr
src/test/ui/lint/lint-malformed.rs
src/test/ui/lint/lint-malformed.stderr
src/test/ui/lint/reasons-erroneous.rs
src/test/ui/lint/reasons-erroneous.stderr
src/test/ui/malformed/malformed-derive-entry.rs
src/test/ui/malformed/malformed-derive-entry.stderr
src/test/ui/malformed/malformed-plugin-1.rs
src/test/ui/malformed/malformed-plugin-1.stderr
src/test/ui/malformed/malformed-plugin-2.rs
src/test/ui/malformed/malformed-plugin-2.stderr
src/test/ui/malformed/malformed-plugin-3.rs
src/test/ui/malformed/malformed-plugin-3.stderr
src/test/ui/malformed/malformed-special-attrs.rs
src/test/ui/malformed/malformed-special-attrs.stderr
src/test/ui/malformed/malformed-unwind-1.rs
src/test/ui/malformed/malformed-unwind-1.stderr
src/test/ui/malformed/malformed-unwind-2.rs
src/test/ui/malformed/malformed-unwind-2.stderr
src/test/ui/marker_trait_attr/marker-attribute-with-values.rs
src/test/ui/marker_trait_attr/marker-attribute-with-values.stderr
src/test/ui/no_crate_type.rs
src/test/ui/no_crate_type.stderr
src/test/ui/on-unimplemented/bad-annotation.rs
src/test/ui/on-unimplemented/bad-annotation.stderr
src/test/ui/proc-macro/attribute.rs
src/test/ui/proc-macro/attribute.stderr
src/test/ui/proc-macro/invalid-attributes.rs
src/test/ui/proc-macro/invalid-attributes.stderr
src/test/ui/repr.rs
src/test/ui/repr.stderr
src/test/ui/rfc-2008-non-exhaustive/invalid-attribute.rs
src/test/ui/rfc-2008-non-exhaustive/invalid-attribute.stderr
src/test/ui/stability-attribute/stability-attribute-sanity-4.rs
src/test/ui/stability-attribute/stability-attribute-sanity-4.stderr
src/test/ui/target-feature-wrong.rs
src/test/ui/target-feature-wrong.stderr