]> git.lizzy.rs Git - rust.git/commit
propagate depth that was reached, not just whether there was a cycle
authorNiko Matsakis <niko@alum.mit.edu>
Mon, 10 Jun 2019 15:46:53 +0000 (11:46 -0400)
committerNiko Matsakis <niko@alum.mit.edu>
Tue, 11 Jun 2019 23:07:32 +0000 (19:07 -0400)
commit5486a860f1d9cf5862beacf3ceace9e84e170f85
treeb0ec1605726ccd3b54e9971d52d91c439250d181
parente64a7bf64b70a9630d1ba8741665158d91f4cca7
propagate depth that was reached, not just whether there was a cycle

I tried to propagate this information with the return value, but I
found a curiosity (actually, something that I'm not keen on in
general) -- in particular, the candidate cache urrently invokes
evaluation, which may detect a cycle, but the "depth" that results
from that are is easily propagated back out. This probably means that
the candidate caching mechanism *itself* is sort of problematic, but
I'm choosing to ignore that in favor of a more ambitious rewrite
later.
src/librustc/traits/select.rs