]> git.lizzy.rs Git - rust.git/commit
Merge #6706
authorbors[bot] <26634292+bors[bot]@users.noreply.github.com>
Tue, 8 Dec 2020 13:10:28 +0000 (13:10 +0000)
committerGitHub <noreply@github.com>
Tue, 8 Dec 2020 13:10:28 +0000 (13:10 +0000)
commit4d4f11925f793c45560c45c088d4b3139c2c171c
treef8c5e3c14a0bb55d4b435b8389bccf305975d39a
parent021e97ea03cf67ad7785ab39580e04bc69506b8c
parentbf24cb3e8db94a84fb4a24c407797ab6ff5ee109
Merge #6706

6706: Move import text edit calculation into a completion resolve request r=matklad a=SomeoneToIgnore

Part of https://github.com/rust-analyzer/rust-analyzer/issues/6612 (presumably fixing it)
Part of https://github.com/rust-analyzer/rust-analyzer/issues/6366 (does not cover all possible resolve capabilities we can do)
Closes https://github.com/rust-analyzer/rust-analyzer/issues/6594

Further improves imports on completion performance by deferring the computations for import inserts.

To use the new mode, you have to have the experimental completions enabled and use the LSP 3.16-compliant client that reports `additionalTextEdits` in its `CompletionItemCapabilityResolveSupport` field in the client capabilities.
rust-analyzer VSCode extension does this already hence picks up the changes completely.

Performance implications are descrbed in: https://github.com/rust-analyzer/rust-analyzer/issues/6633#issuecomment-737295182

Co-authored-by: Kirill Bulatov <mail4score@gmail.com>