]> git.lizzy.rs Git - rust.git/commit
Rollup merge of #54557 - michaelwoerister:dont-auto-share-generics-for-incr-comp...
authorPietro Albini <pietro@pietroalbini.org>
Tue, 25 Sep 2018 20:34:50 +0000 (22:34 +0200)
committerGitHub <noreply@github.com>
Tue, 25 Sep 2018 20:34:50 +0000 (22:34 +0200)
commit4ceeec09efa468700768a21d71bb92d733728887
tree6b82f5c5408db8034faa5a35a4b9860e98e9d2fb
parentbd217b62f66d02b6b8caf14b00c5955eb75786b6
parent8fc7b5d12bfe6b2d7f8705db8bfc7fdcd6704d2e
Rollup merge of #54557 - michaelwoerister:dont-auto-share-generics-for-incr-comp, r=alexcrichton

incr.comp.: Don't automatically enable -Zshare-generics for incr. comp. builds.

So far the compiler would automatically enable sharing of monomorphizations for incremental builds. That was OK because without (Thin)LTO this could have very little impact on the runtime performance of the generated code. However, since https://github.com/rust-lang/rust/pull/53673, ThinLTO and incr. comp. can be combined, so the trade-off is not as clear anymore.

This PR removes the automatic tie between the two options. Whether monomorphizations are shared between crates or not now _only_ depends on the optimization level.

r? @alexcrichton