]> git.lizzy.rs Git - rust.git/commit
Fix another circulare deps link args issue
authorAlex Crichton <alex@alexcrichton.com>
Wed, 4 Apr 2018 23:54:30 +0000 (16:54 -0700)
committerAlex Crichton <alex@alexcrichton.com>
Wed, 4 Apr 2018 23:54:30 +0000 (16:54 -0700)
commit48ede3f031ee81be017923708e5a6e77160e09c3
treedde53cafe98907f9f24b9fdec8a14a01f4fe19d2
parent5758c2dd14fd29caf7c7bb2123eb6b23443b9233
Fix another circulare deps link args issue

It turns out that the support in #49316 wasn't enough to handle all cases
notably the example in #48661. The underlying bug was connected to panic=abort
where lang items were listed in the `missing_lang_items` sets but didn't
actually exist anywhere.

This caused the linker backend to deduce that start-group/end-group wasn't
needed because not all items were defined. Instead the missing lang items that
don't actually need to have a definition are filtered out and not considered for
the start-group/end-group arguments

Closes #48661
src/librustc/middle/weak_lang_items.rs
src/librustc_trans/base.rs
src/librustc_trans/lib.rs
src/test/run-make-fulldeps/std-core-cycle/Makefile