]> git.lizzy.rs Git - rust.git/commit
DST coercions and DST structs
authorNick Cameron <ncameron@mozilla.com>
Mon, 4 Aug 2014 12:20:11 +0000 (14:20 +0200)
committerNick Cameron <ncameron@mozilla.com>
Tue, 26 Aug 2014 00:38:51 +0000 (12:38 +1200)
commit3e626375d8d2226a203bf6ea6e98dab14774c59f
tree9be8320420b1c904670b7e12ccff8bc3080b2eec
parent37a94b80f207e86017e54056ced2dc9674907ae3
DST coercions and DST structs

[breaking-change]

1. The internal layout for traits has changed from (vtable, data) to (data, vtable). If you were relying on this in unsafe transmutes, you might get some very weird and apparently unrelated errors. You should not be doing this! Prefer not to do this at all, but if you must, you should use raw::TraitObject rather than hardcoding rustc's internal representation into your code.

2. The minimal type of reference-to-vec-literals (e.g., `&[1, 2, 3]`) is now a fixed size vec (e.g., `&[int, ..3]`) where it used to be an unsized vec (e.g., `&[int]`). If you want the unszied type, you must explicitly give the type (e.g., `let x: &[_] = &[1, 2, 3]`). Note in particular where multiple blocks must have the same type (e.g., if and else clauses, vec elements), the compiler will not coerce to the unsized type without a hint. E.g., `[&[1], &[1, 2]]` used to be a valid expression of type '[&[int]]'. It no longer type checks since the first element now has type `&[int, ..1]` and the second has type &[int, ..2]` which are incompatible.

3. The type of blocks (including functions) must be coercible to the expected type (used to be a subtype). Mostly this makes things more flexible and not less (in particular, in the case of coercing function bodies to the return type). However, in some rare cases, this is less flexible. TBH, I'm not exactly sure of the exact effects. I think the change causes us to resolve inferred type variables slightly earlier which might make us slightly more restrictive. Possibly it only affects blocks with unreachable code. E.g., `if ... { fail!(); "Hello" }` used to type check, it no longer does. The fix is to add a semicolon after the string.
116 files changed:
src/liballoc/heap.rs
src/libcollections/slice.rs
src/libcore/intrinsics.rs
src/libcore/raw.rs
src/libcore/slice.rs
src/libdebug/reflect.rs
src/libdebug/repr.rs
src/libgreen/context.rs
src/liblibc/lib.rs
src/librlibc/lib.rs
src/librustc/front/test.rs
src/librustc/lint/builtin.rs
src/librustc/metadata/tydecode.rs
src/librustc/metadata/tyencode.rs
src/librustc/middle/astencode.rs
src/librustc/middle/borrowck/mod.rs
src/librustc/middle/cfg/construct.rs
src/librustc/middle/check_const.rs
src/librustc/middle/check_static.rs
src/librustc/middle/const_eval.rs
src/librustc/middle/expr_use_visitor.rs
src/librustc/middle/kind.rs
src/librustc/middle/liveness.rs
src/librustc/middle/mem_categorization.rs
src/librustc/middle/region.rs
src/librustc/middle/trans/_match.rs
src/librustc/middle/trans/adt.rs
src/librustc/middle/trans/base.rs
src/librustc/middle/trans/callee.rs
src/librustc/middle/trans/common.rs
src/librustc/middle/trans/consts.rs
src/librustc/middle/trans/datum.rs
src/librustc/middle/trans/debuginfo.rs
src/librustc/middle/trans/expr.rs
src/librustc/middle/trans/glue.rs
src/librustc/middle/trans/meth.rs
src/librustc/middle/trans/reflect.rs
src/librustc/middle/trans/tvec.rs
src/librustc/middle/trans/type_.rs
src/librustc/middle/trans/type_of.rs
src/librustc/middle/ty.rs
src/librustc/middle/ty_fold.rs
src/librustc/middle/typeck/astconv.rs
src/librustc/middle/typeck/check/_match.rs
src/librustc/middle/typeck/check/demand.rs
src/librustc/middle/typeck/check/method.rs
src/librustc/middle/typeck/check/mod.rs
src/librustc/middle/typeck/check/regionck.rs
src/librustc/middle/typeck/check/vtable.rs
src/librustc/middle/typeck/check/writeback.rs
src/librustc/middle/typeck/coherence.rs
src/librustc/middle/typeck/infer/coercion.rs
src/librustc/middle/typeck/infer/combine.rs
src/librustc/middle/typeck/infer/error_reporting.rs
src/librustc/middle/typeck/infer/sub.rs
src/librustc/middle/typeck/variance.rs
src/librustc/util/ppaux.rs
src/librustc_back/abi.rs
src/librustc_back/svh.rs
src/librustdoc/clean/mod.rs
src/librustdoc/html/render.rs
src/librustuv/homing.rs
src/librustuv/lib.rs
src/libstd/path/posix.rs
src/libstd/path/windows.rs
src/libsyntax/ast.rs
src/libsyntax/ext/build.rs
src/libsyntax/fold.rs
src/libsyntax/parse/mod.rs
src/libsyntax/parse/parser.rs
src/libsyntax/print/pprust.rs
src/libsyntax/util/small_vector.rs
src/libsyntax/visit.rs
src/test/compile-fail/const-cast-different-types.rs
src/test/compile-fail/dst-bad-assign-2.rs [new file with mode: 0644]
src/test/compile-fail/dst-bad-assign.rs [new file with mode: 0644]
src/test/compile-fail/dst-bad-coerce1.rs [new file with mode: 0644]
src/test/compile-fail/dst-bad-coerce2.rs [new file with mode: 0644]
src/test/compile-fail/dst-bad-coerce3.rs [new file with mode: 0644]
src/test/compile-fail/dst-bad-coerce4.rs [new file with mode: 0644]
src/test/compile-fail/dst-bad-deep.rs [new file with mode: 0644]
src/test/compile-fail/issue-10291.rs
src/test/compile-fail/issue-13446.rs
src/test/compile-fail/issue-4523.rs
src/test/compile-fail/issue-4972.rs
src/test/compile-fail/issue-5883.rs
src/test/compile-fail/issue-7013.rs
src/test/compile-fail/lifetime-inference-give-expl-lifetime-param.rs
src/test/compile-fail/lub-if.rs
src/test/compile-fail/lub-match.rs
src/test/compile-fail/regions-early-bound-error-method.rs
src/test/compile-fail/regions-early-bound-error.rs
src/test/compile-fail/regions-glb-free-free.rs
src/test/compile-fail/regions-nested-fns.rs
src/test/compile-fail/regions-ret-borrowed-1.rs
src/test/compile-fail/regions-ret-borrowed.rs
src/test/compile-fail/regions-return-stack-allocated-vec.rs
src/test/compile-fail/trait-bounds-not-on-bare-trait.rs
src/test/run-make/graphviz-flowgraph/f15.dot-expected.dot
src/test/run-make/graphviz-flowgraph/f15.rs
src/test/run-make/graphviz-flowgraph/f16.dot-expected.dot
src/test/run-make/graphviz-flowgraph/f16.rs
src/test/run-pass/check-static-slice.rs [new file with mode: 0644]
src/test/run-pass/const-enum-vec-index.rs
src/test/run-pass/dst-struct-reflect.rs [new file with mode: 0644]
src/test/run-pass/dst-struct-sole.rs [new file with mode: 0644]
src/test/run-pass/dst-struct.rs [new file with mode: 0644]
src/test/run-pass/dst-trait.rs [new file with mode: 0644]
src/test/run-pass/evec-slice.rs
src/test/run-pass/gc-vec.rs [new file with mode: 0644]
src/test/run-pass/issue-7012.rs
src/test/run-pass/issue-9259.rs
src/test/run-pass/overloaded-deref-count.rs
src/test/run-pass/reflect-visit-type.rs
src/test/run-pass/smallest-hello-world.rs
src/test/run-pass/vec-dst.rs [new file with mode: 0644]