]> git.lizzy.rs Git - rust.git/commit
Replace str's transmute() calls with pointer casts
authorIxrec <ericrhitchcock@gmail.com>
Sun, 17 Sep 2017 16:03:56 +0000 (17:03 +0100)
committerGitHub <noreply@github.com>
Sun, 17 Sep 2017 16:03:56 +0000 (17:03 +0100)
commit2633b85ab2c89822d2c227fc9e81c6ec1c0ed9b6
tree153dd6766670875f2940c36f8e057a8bde27eae4
parentef227f5ffe438783db0add58208d79dd84158c06
Replace str's transmute() calls with pointer casts

After the following conversation in #rust-lang:
```
[14:43:50] <Ixrec> TIL the implementation of from_utf_unchecked is literally just "mem::transmute(x)"
[14:43:59] <Ixrec> no wonder people keep saying transmute is overpowered
[15:15:30] <eddyb> Ixrec: it should be a pointer cast lol
[15:15:46] <eddyb> unless it doesn't let you
[16:50:34] <Ixrec> https://play.rust-lang.org/?gist=d1e6b629ad9ec1baf64ce261c63845e6&version=stable seems like it does let me
[16:52:35] <eddyb> Ixrec: yeah that's the preferred impl
[16:52:46] <eddyb> Ixrec: it just wasn't in 1.0
[16:52:50] <eddyb> IIRC
[16:53:00] <eddyb> (something something fat pointers)
```
Since I already wrote half of the preferred impls in the playground, might as well make an actual PR.
src/libcore/str/mod.rs