]> git.lizzy.rs Git - rust.git/commit
Auto merge of #92686 - saethlin:unsafe-debug-asserts, r=Amanieu
authorbors <bors@rust-lang.org>
Sun, 3 Apr 2022 16:04:47 +0000 (16:04 +0000)
committerbors <bors@rust-lang.org>
Sun, 3 Apr 2022 16:04:47 +0000 (16:04 +0000)
commit168a0209002fef203e83989ff641c1b3e1a51859
tree3677c86e0de2975e8ce62c9336288a6001aea489
parent15a242a432c9c40a60def102209a5d40900b7b9d
parent6e6d0cbf838fef856abd5b5c63d1f156c4ebfe72
Auto merge of #92686 - saethlin:unsafe-debug-asserts, r=Amanieu

Add debug assertions to some unsafe functions

As suggested by https://github.com/rust-lang/rust/issues/51713

~~Some similar code calls `abort()` instead of `panic!()` but aborting doesn't work in a `const fn`, and the intrinsic for doing dispatch based on whether execution is in a const is unstable.~~

This picked up some invalid uses of `get_unchecked` in the compiler, and fixes them.

I can confirm that they do in fact pick up invalid uses of `get_unchecked` in the wild, though the user experience is less-than-awesome:
```
     Running unittests (target/x86_64-unknown-linux-gnu/debug/deps/rle_decode_fast-04b7918da2001b50)

running 6 tests
error: test failed, to rerun pass '--lib'

Caused by:
  process didn't exit successfully: `/home/ben/rle-decode-helper/target/x86_64-unknown-linux-gnu/debug/deps/rle_decode_fast-04b7918da2001b50` (signal: 4, SIGILL: illegal instruction)
```

~~As best I can tell these changes produce a 6% regression in the runtime of `./x.py test` when `[rust] debug = true` is set.~~
Latest commit (https://github.com/rust-lang/rust/pull/92686/commits/6894d559bdb4365243b3f4bf73f18e4b1bed04d1) brings the additional overhead from this PR down to 0.5%, while also adding a few more assertions. I think this actually covers all the places in `core` that it is reasonable to check for safety requirements at runtime.

Thoughts?
library/core/src/intrinsics.rs
library/core/src/num/nonzero.rs
library/core/src/ptr/mod.rs
library/core/src/slice/index.rs
library/core/src/slice/mod.rs
library/core/src/slice/raw.rs