]> git.lizzy.rs Git - rust.git/commit
Auto merge of #47657 - algesten:save-analysis-impls, r=nrc
authorbors <bors@rust-lang.org>
Sun, 11 Feb 2018 05:29:20 +0000 (05:29 +0000)
committerbors <bors@rust-lang.org>
Sun, 11 Feb 2018 05:29:20 +0000 (05:29 +0000)
commit0bb8935136098dde90d6dcbf24237fd7e2fe569f
tree98aab9d3332fa002439694194a7a85328ae8c6ef
parent7f2baba12182123012458d8b09f84a04ae8c1e7c
parent9a6afa8f670af6da28a62c551d9df1fbe51b7434
Auto merge of #47657 - algesten:save-analysis-impls, r=nrc

Emit data::Impl in save-analysis

As discussed on [internals.rust-lang](https://internals.rust-lang.org/t/rustdoc2-rls-analysis-and-the-compiler-help-wanted/6592/5), this PR emits `rls-data::Impl` in the save-analysis.

A number of questions are outstanding:

- [x] A few `???` around row 356. We need to discuss what goes here, if anything.
- [ ] ~~Deriving `id` for impl using hashing. Is this going to clash with rustc defids?~~
- [ ] ~~Deriving `id` for impl using hashing. Is the conversion from 64 bit -> 32 bit problematic?~~
- [x] Need a new rls-data with an `id` field in `Impl` struct.
- [ ] ~~Need a new rls-data which `derive` `Hash` for `ImplKind` enum.~~