]> git.lizzy.rs Git - rust.git/commit
rustc: Continue to tweak "std internal symbols"
authorAlex Crichton <alex@alexcrichton.com>
Thu, 23 Aug 2018 07:33:32 +0000 (00:33 -0700)
committerAlex Crichton <alex@alexcrichton.com>
Sun, 26 Aug 2018 23:34:14 +0000 (16:34 -0700)
commit0a2282e1286823c06ee9c4fa5e49544fc4f47771
treebffd2f09af5259ef0670a5fc37dc4c4005b73bb1
parentcaed80ba4ba8d9f4d3fa8aa9af6c4092d779cd9d
rustc: Continue to tweak "std internal symbols"

In investigating [an issue][1] with `panic_implementation` defined in an
executable that's optimized I once again got to rethinking a bit about the
`rustc_std_internal_symbol` attribute as well as weak lang items. We've sort of
been non-stop tweaking these items ever since their inception, and this
continues to the trend.

The crux of the bug was that in the reachability we have a [different branch][2]
for non-library builds which meant that weak lang items (and std internal
symbols) weren't considered reachable, causing them to get eliminiated by
ThinLTO passes. The fix was to basically tweak that branch to consider these
symbols to ensure that they're propagated all the way to the linker.

Along the way I've attempted to erode the distinction between std internal
symbols and weak lang items by having weak lang items automatically configure
fields of `CodegenFnAttrs`. That way most code no longer even considers weak
lang items and they're simply considered normal functions with attributes about
the ABI.

In the end this fixes the final comment of #51342

[1]: https://github.com/rust-lang/rust/issues/51342#issuecomment-414368019
[2]: https://github.com/rust-lang/rust/blob/35bf1ae25799a4e62131159f052e0a3cbd27c960/src/librustc/middle/reachable.rs#L225-L238
15 files changed:
src/liballoc_jemalloc/lib.rs
src/libpanic_abort/lib.rs
src/librustc/hir/mod.rs
src/librustc/ich/impls_hir.rs
src/librustc/middle/reachable.rs
src/librustc_allocator/expand.rs
src/librustc_codegen_utils/symbol_names.rs
src/librustc_mir/monomorphize/collector.rs
src/librustc_mir/monomorphize/partitioning.rs
src/librustc_typeck/collect.rs
src/libstd/alloc.rs
src/test/run-make/wasm-symbols-not-imported/Makefile [new file with mode: 0644]
src/test/run-make/wasm-symbols-not-imported/foo.rs [new file with mode: 0644]
src/test/run-make/wasm-symbols-not-imported/verify-no-imports.js [new file with mode: 0644]
src/test/ui/panic-handler/panic-handler-std.stderr